Copy improvements to golden files from broker repo

[adombeck]

Copy the changes to the code for handling golden files from the broker repo.

UDENG-5447

[3v1n0]

Wouldn't be better to have this somewhat public (or in a shared repo) so that we can import in both places?

[adombeck]

Wouldn't be better to have this somewhat public (or in a shared repo) so that we can import in both places?

Yes, we want to do that at some point, but it requires analyzing the needs of our other repos (adsys, pro for wsl, ...) first, so we postponed that (see the thread in our MM channel)

[adombeck]

The PAM SSH integration test failed but I don't see any error in the output. @3v1n0 do you have an idea what's going on there?

[adombeck]

The full logs from the uploaded artifacts contain more output:

❌ TestSSHAuthenticate/Authenticate_user_and_offer_password_reset_on_shared_SSHd (FAIL; 27.09s)
    ssh_test.go:266: 
        	Error Trace:	/home/runner/work/authd/authd/pam/integration-tests/ssh_test.go:266
        	Error:      	Not equal: 
        	            	expected: "> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-can-reset@localhost) Choose your provider:\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-can-reset@localhost) Choose your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-can-reset@localhost) Gimme your password:\n>\n───────────────────────────────────────────────────────────────────────────────
─\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-can-reset@localhost) Choose your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-can-reset@localhost) Gimme your password:\n>\n== Password reset ==\n  1. Proceed with password update\n  2. Skip\nOr enter 'r' to go back to choose the provider\n(user-can-reset@localhost) Choose action:\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-can-reset@localhost) Choose your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication
 method\n(user-can-reset@localhost) Gimme your password:\n>\n== Password reset ==\n  1. Proceed with password update\n  2. Skip\nOr enter 'r' to go back to choose the provider\n(user-can-reset@localhost) Choose action:\n> 2\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-can-reset@localhost) Choose your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-can-reset@localhost) Gimme your password:\n>\n== Password reset ==\n  1. Proceed with password update\n  2. Skip\nOr enter 'r' to go back to choose the provider\n(user-can-reset@localhost) Choose action:\n> 2\n SSHD: Connected to ssh via authd module! [TestSSHAuthe
nticate]\n  HOME=${AUTHD_TEST_HOME}\n  LOGNAME=user-can-reset\n  PATH=${AUTHD_TEST_PATH}\n  PWD=${AUTHD_TEST_PWD}\n  SHELL=/bin/sh\n  SSH_CLIENT=${AUTHD_TEST_SSH_CLIENT}\n  SSH_CONNECTION=${AUTHD_TEST_SSH_CONNECTION}\n  SSH_TTY=${AUTHD_TEST_SSH_TTY}\n  TERM=xterm-256color\n  USER=user-can-reset\nConnection to localhost closed.\n>\n────────────────────────────────────────────────────────────────────────────────\n"
        	            	actual  : "> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-can-reset@localhost) Choose your provider:\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-can-reset@localhost) Choose your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-can-reset@localhost) Gimme your password:\n>\n───────────────────────────────────────────────────────────────────────────────
─\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-can-reset@localhost) Choose your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-can-reset@localhost) Gimme your password:\n>\n== Password reset ==\n  1. Proceed with password update\n  2. Skip\nOr enter 'r' to go back to choose the provider\n(user-can-reset@localhost) Choose action:\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-can-reset@localhost) Choose your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication
 method\n(user-can-reset@localhost) Gimme your password:\n>\n== Password reset ==\n  1. Proceed with password update\n  2. Skip\nOr enter 'r' to go back to choose the provider\n(user-can-reset@localhost) Choose action:\n> 2\n SSHD: Connected to ssh via authd module! [TestSSHAuthenticate]\n  HOME=${AUTHD_TEST_HOME}\n  LOGNAME=user-can-reset\n  PATH=${AUTHD_TEST_PATH}\n  PWD=${AUTHD_TEST_PWD}\n  SHELL=/bin/sh\n  SSH_CLIENT=${AUTHD_TEST_SSH_CLIENT}\n  SSH_CONNECTION=${AUTHD_TEST_SSH_CONNECTION}\n  SSH_TTY=${AUTHD_TEST_SSH_TTY}\n  TERM=xterm-256color\n  USER=user-can-reset\nConnection to localhost closed.\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-can-reset@localhost) Choose your provider:\n
> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-can-reset@localhost) Gimme your password:\n>\n== Password reset ==\n  1. Proceed with password update\n  2. Skip\nOr enter 'r' to go back to choose the provider\n(user-can-reset@localhost) Choose action:\n> 2\n SSHD: Connected to ssh via authd module! [TestSSHAuthenticate]\n  HOME=${AUTHD_TEST_HOME}\n  LOGNAME=user-can-reset\n  PATH=${AUTHD_TEST_PATH}\n  PWD=${AUTHD_TEST_PWD}\n  SHELL=/bin/sh\n  SSH_CLIENT=${AUTHD_TEST_SSH_CLIENT}\n  SSH_CONNECTION=${AUTHD_TEST_SSH_CONNECTION}\n  SSH_TTY=${AUTHD_TEST_SSH_TTY}\n  TERM=xterm-256color\n  USER=user-can-reset\nConnection to localhost closed.\n>\n────────────────────────────────────────────────────────────────────────────────\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -51,2 +51,15 @@
        	            	 > 2
        	            	+ SSHD: Connected to ssh via authd module! [TestSSHAuthenticate]
        	            	+  HOME=${AUTHD_TEST_HOME}
        	            	+  LOGNAME=user-can-reset
        	            	+  PATH=${AUTHD_TEST_PATH}
        	            	+  PWD=${AUTHD_TEST_PWD}
        	            	+  SHELL=/bin/sh
        	            	+  SSH_CLIENT=${AUTHD_TEST_SSH_CLIENT}
        	            	+  SSH_CONNECTION=${AUTHD_TEST_SSH_CONNECTION}
        	            	+  SSH_TTY=${AUTHD_TEST_SSH_TTY}
        	            	+  TERM=xterm-256color
        	            	+  USER=user-can-reset
        	            	+Connection to localhost closed.
        	            	+>
        	            	 ────────────────────────────────────────────────────────────────────────────────
        	Test:       	TestSSHAuthenticate/Authenticate_user_and_offer_password_reset_on_shared_SSHd
        	Messages:   	Output of tape "optional_password_reset_skip" does not match golden file
    helpers_test.go:169: Saving test artifacts at /tmp/authd-test-artifacts-Ayggff

❌ TestSSHAuthenticate/Prevent_user_from_switching_username_on_shared_SSHd (FAIL; 29.31s)
    ssh_test.go:266: 
        	Error Trace:	/home/runner/work/authd/authd/pam/integration-tests/ssh_test.go:266
        	Error:      	Not equal: 
        	            	expected: "> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n>\n────────────────────────────────────────────
────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n=
= Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n== Authentication method selection ==\n  1. Password authentication\n  2. Use a Login code\n  3. Send URL to user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@\ngmail.com\n  4. Use your fido device foo\n  5. Use your phone +33...\n  6. Use your phone +1...\n  7. Pin code\n  8. Authentication code\nOr enter 'r' to go back to choose the provider\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne 
your authentication method:\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n== Authentication method selection ==\n  1. Password authentication\n  2. Use a Login code\n  3. Send URL to user-integration-pre-check-prev
ent-user-from-switching-username-on-shared-sshd@\ngmail.com\n  4. Use your fido device foo\n  5. Use your phone +33...\n  6. Use your phone +1...\n  7. Pin code\n  8. Authentication code\nOr enter 'r' to go back to choose the provider\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your authentication method:\n> r\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n
> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n== Authentication method selection ==\n  1. Password authentication\n  2. Use a Login code\n  3. Send URL to user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@\ngmail.com\n  4. Use your fido device foo\n  5. Use your phone +33...\n  6. Use your phone +1...\n  7. Pin code\n  8. Authentication code\nOr enter 'r' to go back to choose the provider\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your authentication method:\n> r\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@l
ocalhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password
:\n>\n== Authentication method selection ==\n  1. Password authentication\n  2. Use a Login code\n  3. Send URL to user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@\ngmail.com\n  4. Use your fido device foo\n  5. Use your phone +33...\n  6. Use your phone +1...\n  7. Pin code\n  8. Authentication code\nOr enter 'r' to go back to choose the provider\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your authentication method:\n> r\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n>\n─────────────────
───────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n== Authentication method selection ==\n  1. Password authentication\n  2. Use a Login code\n  3. Send URL to user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@\ngmail.com\n  4. Use your fido dev
ice foo\n  5. Use your phone +33...\n  6. Use your phone +1...\n  7. Pin code\n  8. Authentication code\nOr enter 'r' to go back to choose the provider\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your authentication method:\n> r\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n────────────────
────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n== Authentication method selection ==\n  1. Password authentication\n  2. Use a Login code\n  3. Send URL to user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@\ngmail.com\n  4. Use your fido 
device foo\n  5. Use your phone +33...\n  6. Use your phone +1...\n  7. Pin code\n  8. Authentication code\nOr enter 'r' to go back to choose the provider\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your authentication method:\n> r\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n───────────────
─────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n== Authentication method selection ==\n  1. Password authentication\n  2. Use a Login code\n  3. Send URL to user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@\ngmail.com\n  4. Use your fi
do device foo\n  5. Use your phone +33...\n  6. Use your phone +1...\n  7. Pin code\n  8. Authentication code\nOr enter 'r' to go back to choose the provider\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your authentication method:\n> r\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n SSHD: Connected to ssh via authd module! 
[TestSSHAuthenticate]\n  HOME=${AUTHD_TEST_HOME}\n  LOGNAME=user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd\n  PATH=${AUTHD_TEST_PATH}\n  PWD=${AUTHD_TEST_PWD}\n  SHELL=/bin/sh\n  SSH_CLIENT=${AUTHD_TEST_SSH_CLIENT}\n  SSH_CONNECTION=${AUTHD_TEST_SSH_CONNECTION}\n  SSH_TTY=${AUTHD_TEST_SSH_TTY}\n  TERM=xterm-256color\n  USER=user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd\nConnection to localhost closed.\n>\n────────────────────────────────────────────────────────────────────────────────\n"
        	            	actual  : "> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n>\n────────────────────────────────────────────
────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n=
= Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n== Authentication method selection ==\n  1. Password authentication\n  2. Use a Login code\n  3. Send URL to user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@\ngmail.com\n  4. Use your fido device foo\n  5. Use your phone +33...\n  6. Use your phone +1...\n  7. Pin code\n  8. Authentication code\nOr enter 'r' to go back to choose the provider\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne 
your authentication method:\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n== Authentication method selection ==\n  1. Password authentication\n  2. Use a Login code\n  3. Send URL to user-integration-pre-check-prev
ent-user-from-switching-username-on-shared-sshd@\ngmail.com\n  4. Use your fido device foo\n  5. Use your phone +33...\n  6. Use your phone +1...\n  7. Pin code\n  8. Authentication code\nOr enter 'r' to go back to choose the provider\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your authentication method:\n> r\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n
> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n== Authentication method selection ==\n  1. Password authentication\n  2. Use a Login code\n  3. Send URL to user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@\ngmail.com\n  4. Use your fido device foo\n  5. Use your phone +33...\n  6. Use your phone +1...\n  7. Pin code\n  8. Authentication code\nOr enter 'r' to go back to choose the provider\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your authentication method:\n> r\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@l
ocalhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password
:\n>\n== Authentication method selection ==\n  1. Password authentication\n  2. Use a Login code\n  3. Send URL to user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@\ngmail.com\n  4. Use your fido device foo\n  5. Use your phone +33...\n  6. Use your phone +1...\n  7. Pin code\n  8. Authentication code\nOr enter 'r' to go back to choose the provider\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your authentication method:\n> r\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n>\n─────────────────
───────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n== Authentication method selection ==\n  1. Password authentication\n  2. Use a Login code\n  3. Send URL to user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@\ngmail.com\n  4. Use your fido dev
ice foo\n  5. Use your phone +33...\n  6. Use your phone +1...\n  7. Pin code\n  8. Authentication code\nOr enter 'r' to go back to choose the provider\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your authentication method:\n> r\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n────────────────
────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n== Authentication method selection ==\n  1. Password authentication\n  2. Use a Login code\n  3. Send URL to user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@\ngmail.com\n  4. Use your fido 
device foo\n  5. Use your phone +33...\n  6. Use your phone +1...\n  7. Pin code\n  8. Authentication code\nOr enter 'r' to go back to choose the provider\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your authentication method:\n> r\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n SSHD: Connected to ssh via authd module! [Te
stSSHAuthenticate]\n  HOME=${AUTHD_TEST_HOME}\n  LOGNAME=user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd\n  PATH=${AUTHD_TEST_PATH}\n  PWD=${AUTHD_TEST_PWD}\n  SHELL=/bin/sh\n  SSH_CLIENT=${AUTHD_TEST_SSH_CLIENT}\n  SSH_CONNECTION=${AUTHD_TEST_SSH_CONNECTION}\n  SSH_TTY=${AUTHD_TEST_SSH_TTY}\n  TERM=xterm-256color\n  USER=user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd\nConnection to localhost closed.\n>\n────────────────────────────────────────────────────────────────────────────────\n> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switch
ing-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n== Authentication method selection ==\n  1. Password authentication\n  2. Use a Login code\n  3. Send URL to user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@\ngmail.com\n  4. Use your fido device foo\n  5. Use your phone +33...\n  6. Use your phone +1...\n  7. Pin code\n  8. Authentication code\nOr enter 'r' to go back to choose the provider\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your authentication method:\n> r\n== Provider selection ==\n  1. local\n  2. ExampleBroker\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration
-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> r\nUnsupported input\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos\ne your provider:\n> 2\n== Password authentication ==\nEnter 'r' to cancel the request and go back to select the authentication method\n(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme\n your password:\n>\n SSHD: Connected to ssh via authd module! [TestSSHAuthenticate]\n  HOME=${AUTHD_TEST_HOME}\n  LOGNAME=user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd\n  PATH=${AUTHD_TEST_PATH}\n  PWD=${AUTHD_TEST_PWD}\n  SHELL=/bin/sh\n  SSH_CLIENT=${AUTHD_TEST_SSH_CLIENT}\n  SSH_CONNECTION=${AUTHD_TEST_SSH_CONNECTION}\n  SSH_TTY=${AUTHD_TEST_SSH_TTY}\n  TERM=xterm-256color\n  USER=user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd\nConnection to localhost closed.\n>\n───────────
─────────────────────────────────────────────────────────────────────\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -189,52 +189,2 @@
        	            	 e your provider:
        	            	->
        	            	-────────────────────────────────────────────────────────────────────────────────
        	            	-> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}
        	            	-== Provider selection ==
        	            	-  1. local
        	            	-  2. ExampleBroker
        	            	-(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos
        	            	-e your provider:
        	            	-> r
        	            	-Unsupported input
        	            	-(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos
        	            	-e your provider:
        	            	-> 2
        	            	-== Password authentication ==
        	            	-Enter 'r' to cancel the request and go back to select the authentication method
        	            	-(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme
        	            	- your password:
        	            	->
        	            	-== Authentication method selection ==
        	            	-  1. Password authentication
        	            	-  2. Use a Login code
        	            	-  3. Send URL to user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@
        	            	-gmail.com
        	            	-  4. Use your fido device foo
        	            	-  5. Use your phone +33...
        	            	-  6. Use your phone +1...
        	            	-  7. Pin code
        	            	-  8. Authentication code
        	            	-Or enter 'r' to go back to choose the provider
        	            	-(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos
        	            	-e your authentication method:
        	            	-> r
        	            	-== Provider selection ==
        	            	-  1. local
        	            	-  2. ExampleBroker
        	            	-(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos
        	            	-e your provider:
        	            	-> r
        	            	-Unsupported input
        	            	-(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos
        	            	-e your provider:
        	            	-> r
        	            	-Unsupported input
        	            	-(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos
        	            	-e your provider:
        	            	-> 2
        	            	-== Password authentication ==
        	            	-Enter 'r' to cancel the request and go back to select the authentication method
        	            	-(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme
        	            	- your password:
        	            	 >
        	            	@@ -354,2 +304,65 @@
        	            	 ────────────────────────────────────────────────────────────────────────────────
        	            	+> ssh ${AUTHD_PAM_SSH_USER}@localhost ${AUTHD_PAM_SSH_ARGS}
        	            	+== Provider selection ==
        	            	+  1. local
        	            	+  2. ExampleBroker
        	            	+(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos
        	            	+e your provider:
        	            	+> r
        	            	+Unsupported input
        	            	+(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos
        	            	+e your provider:
        	            	+> 2
        	            	+== Password authentication ==
        	            	+Enter 'r' to cancel the request and go back to select the authentication method
        	            	+(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme
        	            	+ your password:
        	            	+>
        	            	+== Authentication method selection ==
        	            	+  1. Password authentication
        	            	+  2. Use a Login code
        	            	+  3. Send URL to user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@
        	            	+gmail.com
        	            	+  4. Use your fido device foo
        	            	+  5. Use your phone +33...
        	            	+  6. Use your phone +1...
        	            	+  7. Pin code
        	            	+  8. Authentication code
        	            	+Or enter 'r' to go back to choose the provider
        	            	+(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos
        	            	+e your authentication method:
        	            	+> r
        	            	+== Provider selection ==
        	            	+  1. local
        	            	+  2. ExampleBroker
        	            	+(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos
        	            	+e your provider:
        	            	+> r
        	            	+Unsupported input
        	            	+(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos
        	            	+e your provider:
        	            	+> r
        	            	+Unsupported input
        	            	+(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Choos
        	            	+e your provider:
        	            	+> 2
        	            	+== Password authentication ==
        	            	+Enter 'r' to cancel the request and go back to select the authentication method
        	            	+(user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd@localhost) Gimme
        	            	+ your password:
        	            	+>
        	            	+ SSHD: Connected to ssh via authd module! [TestSSHAuthenticate]
        	            	+  HOME=${AUTHD_TEST_HOME}
        	            	+  LOGNAME=user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd
        	            	+  PATH=${AUTHD_TEST_PATH}
        	            	+  PWD=${AUTHD_TEST_PWD}
        	            	+  SHELL=/bin/sh
        	            	+  SSH_CLIENT=${AUTHD_TEST_SSH_CLIENT}
        	            	+  SSH_CONNECTION=${AUTHD_TEST_SSH_CONNECTION}
        	            	+  SSH_TTY=${AUTHD_TEST_SSH_TTY}
        	            	+  TERM=xterm-256color
        	            	+  USER=user-integration-pre-check-prevent-user-from-switching-username-on-shared-sshd
        	            	+Connection to localhost closed.
        	            	+>
        	            	+────────────────────────────────────────────────────────────────────────────────
        	            	 
        	Test:       	TestSSHAuthenticate/Prevent_user_from_switching_username_on_shared_SSHd
        	Messages:   	Output of tape "switch_preset_username" does not match golden file

Not sure why that was not printed in the GitHub Action output, both are produced by gotestfmt 🤔

[adombeck]

The PAM SSH integration test failed

I can't reproduce that failure locally

[adombeck]

The failing tests are just flakiness, it's filed in #673.

[denisonbarbosa]

Changes look good besides one detail: you added the golden package directly under internal/ instead of under internal/testutils as we talked about in the broker repo.

[adombeck]

Changes look good besides one detail: you added the golden package directly under internal/ instead of under internal/testutils as we talked about in the broker repo.

I moved it to internal/testutils/golden/.

[denisonbarbosa]

LGTM!