Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty definition from google #6

Closed
wants to merge 3 commits into from
Closed

Conversation

didrocks
Copy link
Member

Instead of using our own, use the empty google message in the predefined repository.

@didrocks didrocks requested a review from a team as a code owner July 28, 2023 15:29
@didrocks didrocks marked this pull request as draft July 28, 2023 15:32
@didrocks
Copy link
Member Author

Converting to draft, it seems that we are not using the correct version of protoc in CI. This needs to be digged in.

@didrocks didrocks marked this pull request as ready for review July 31, 2023 08:16
@didrocks
Copy link
Member Author

Code generation now pass with the composite action always installing latest protoc: canonical/desktop-engineering@327efac. Let’s try to always roll with latest and revisit if we need to pin a given version at some point.

Copy link
Member

@denisonbarbosa denisonbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's worth it though... We are adding a new dependency to some packages in order to save a couple of lines in our proto file and it looks strange to have one of our service types separated in another place, no? This feels like "violating" one of the "goverbs" (a little copy is better than a little dependency)

@didrocks
Copy link
Member Author

didrocks commented Aug 1, 2023

After a good night of thoughts, I think you are right. This has more drawbacks than advantages. Well, at least, that allowed me to fix the generation action to take latest protoc available rather than the one in the current distro. Let’s withdraw.

@didrocks didrocks closed this Aug 1, 2023
@didrocks didrocks deleted the empty_definition_from_google branch September 14, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants