fix(examplebroker): Use locked access to isAuthenticatedCalls on end session #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a data race, since we were accessing to the isAuthenticatedCalls map without locking, fix this avoiding lock/unlock dance. WARNING: DATA RACE Read at 0x00c0001a03f0 by goroutine 311: runtime.mapaccess2_faststr() /opt/hostedtoolcache/go/1.23.0/x64/src/runtime/map_faststr.go:117 +0x0 github.com/ubuntu/authd/examplebroker.(*Broker).EndSession() /home/runner/work/authd/authd/examplebroker/broker.go:733 +0xf9 github.com/ubuntu/authd/examplebroker.(*Bus).EndSession() /home/runner/work/authd/authd/examplebroker/dbus.go:115 +0x5b runtime.call32() /opt/hostedtoolcache/go/1.23.0/x64/src/runtime/asm_amd64.s:776 +0x42 reflect.Value.Call() /opt/hostedtoolcache/go/1.23.0/x64/src/reflect/value.go:365 +0xb5 github.com/godbus/dbus/v5.exportedMethod.Call() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/default_handler.go:128 +0x239 github.com/godbus/dbus/v5.(*exportedMethod).Call() <autogenerated>:1 +0x84 github.com/godbus/dbus/v5.(*Conn).handleCall() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/export.go:193 +0x6f2 github.com/godbus/dbus/v5.(*Conn).inWorker.gowrap1() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/conn.go:435 +0x44 Previous write at 0x00c0001a03f0 by goroutine 308: runtime.mapassign_faststr() /opt/hostedtoolcache/go/1.23.0/x64/src/runtime/map_faststr.go:223 +0x0 github.com/ubuntu/authd/examplebroker.(*Broker).IsAuthenticated() /home/runner/work/authd/authd/examplebroker/broker.go:537 +0x276 github.com/ubuntu/authd/examplebroker.(*Bus).IsAuthenticated() /home/runner/work/authd/authd/examplebroker/dbus.go:106 +0x91 runtime.call64() /opt/hostedtoolcache/go/1.23.0/x64/src/runtime/asm_amd64.s:777 +0x42 reflect.Value.Call() /opt/hostedtoolcache/go/1.23.0/x64/src/reflect/value.go:365 +0xb5 github.com/godbus/dbus/v5.exportedMethod.Call() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/default_handler.go:128 +0x239 github.com/godbus/dbus/v5.(*exportedMethod).Call() <autogenerated>:1 +0x84 github.com/godbus/dbus/v5.(*Conn).handleCall() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/export.go:193 +0x6f2 github.com/godbus/dbus/v5.(*Conn).inWorker.gowrap1() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/conn.go:435 +0x44 Goroutine 311 (running) created at: github.com/godbus/dbus/v5.(*Conn).inWorker() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/conn.go:435 +0x46a github.com/godbus/dbus/v5.(*Conn).Auth.gowrap1() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/auth.go:118 +0x33 Goroutine 308 (running) created at: github.com/godbus/dbus/v5.(*Conn).inWorker() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/conn.go:435 +0x46a github.com/godbus/dbus/v5.(*Conn).Auth.gowrap1() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/auth.go:118 +0x33 github.com/godbus/dbus/v5.(*Conn).inWorker.gowrap1() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/conn.go:435 +0x44 Previous write at 0x00c0001a03f0 by goroutine 308: runtime.mapassign_faststr() /opt/hostedtoolcache/go/1.23.0/x64/src/runtime/map_faststr.go:223 +0x0 github.com/ubuntu/authd/examplebroker.(*Broker).IsAuthenticated() /home/runner/work/authd/authd/examplebroker/broker.go:537 +0x276 github.com/ubuntu/authd/examplebroker.(*Bus).IsAuthenticated() /home/runner/work/authd/authd/examplebroker/dbus.go:106 +0x91 runtime.call64() /opt/hostedtoolcache/go/1.23.0/x64/src/runtime/asm_amd64.s:777 +0x42 reflect.Value.Call() /opt/hostedtoolcache/go/1.23.0/x64/src/reflect/value.go:365 +0xb5 github.com/godbus/dbus/v5.exportedMethod.Call() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/default_handler.go:128 +0x239 github.com/godbus/dbus/v5.(*exportedMethod).Call() <autogenerated>:1 +0x84 github.com/godbus/dbus/v5.(*Conn).handleCall() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/export.go:193 +0x6f2 github.com/godbus/dbus/v5.(*Conn).inWorker.gowrap1() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/conn.go:435 +0x44 Goroutine 311 (running) created at: github.com/godbus/dbus/v5.(*Conn).inWorker() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/conn.go:435 +0x46a github.com/godbus/dbus/v5.(*Conn).Auth.gowrap1() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/auth.go:118 +0x33 Goroutine 308 (running) created at: github.com/godbus/dbus/v5.(*Conn).inWorker() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/conn.go:435 +0x46a github.com/godbus/dbus/v5.(*Conn).Auth.gowrap1() /home/runner/go/pkg/mod/github.com/godbus/dbus/[email protected]/auth.go:118 +0x33
3v1n0
force-pushed
the
example-broker-cancel-race
branch
from
f600537
to
01e2dc5
Compare
denisonbarbosa
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a data race, since we were accessing to the isAuthenticatedCalls map without locking, fix this avoiding lock/unlock dance.
See: https://github.com/ubuntu/authd/actions/runs/11153104769/job/30999989707