Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint(pam/integration-tests): Cleanup tests code reducing duplicates and add some docs #567

Merged
merged 9 commits into from
Oct 3, 2024
Merged

maint(pam/integration-tests): Cleanup tests code reducing duplicates and add some docs #567

merged 9 commits into from
Oct 3, 2024

Commits on Oct 3, 2024

  1. pam/integration-tests: Factorize code in VHS-based integration tests 

    We've lots of similar code that is hard to maintain in the VHS tests, so
factorize it and use the same helpers in all the tests to manage the VHS
setup and launch.
    @3v1n0
    3v1n0 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ab927ba View commit details
    Browse the repository at this point in the history

  2. pam/integration-tests: Cleanup the PAM client log initialization

    @3v1n0
    3v1n0 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3ca09c8 View commit details
    Browse the repository at this point in the history

  3. pam/integration-tests: Move all the generic helpers to the helpers file 

    These are not related to the cli tests anymore
    @3v1n0
    3v1n0 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    bac3967 View commit details
    Browse the repository at this point in the history

  4. pam: Move the PAM Test Client to tools 

    It's not something that we need to build by default, being used only by
tests or for manual testing, so move it out from pam folder since it
doesn't need to access to any pam-private stuff either
    @3v1n0
    3v1n0 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    49a979a View commit details
    Browse the repository at this point in the history

  5. pam: Remove the duality between PAM Client's 

    We've two types of clients:
 - The PAM Application Test Client that is used to start a PAM transaction
   And now we refer to it as the PAM Runner.
 - The PAM Exec Child Client that is the app implementing the PAM module
   API through DBus.

So hopefully clarify this
    @3v1n0
    3v1n0 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ab6e2e6 View commit details
    Browse the repository at this point in the history

  6. tests: Produce binaries with more debugging symbols for testing

    @3v1n0
    3v1n0 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    fdd11b1 View commit details
    Browse the repository at this point in the history

  7. pam/integration-tests: Compile the test client with PAM debug

    @3v1n0
    3v1n0 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3b357f8 View commit details
    Browse the repository at this point in the history

  8. pam/integration-tests: Use multi-line test cases to improve maintaina… 

    …bility

Adding new options or settings to a test makes it hard to read, so
split the test cases to be in multi-line mode
    @3v1n0
    3v1n0 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    732bf94 View commit details
    Browse the repository at this point in the history

  9. PAM: Add an Hacking document to explain better the architecture

    @3v1n0
    3v1n0 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    efa8336 View commit details
    Browse the repository at this point in the history