pam/native-model: Do not render qr code in SSH sessions at all #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not renderer qrcode in SSH at all, the only clients supporting it are putty and `ssh` provided by ubuntu (>= 24.04), and it's not possible (yet) to detect this from PAM level, so let's just ignore it for now. And add an integration test covering this case Closes: ubuntu#497
Only render it on terminal TTYs, as if the module gets loaded somewhere else (polkit renderers, un-patched gdm, any other desktop greeter like lightdm), it wouldn't work anyways. So, just support it in the platforms we know it works instead
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
=======================================
Coverage 84.61% 84.61%
=======================================
Files 79 79
Lines 6953 6955 +2
Branches 75 75
=======================================
+ Hits 5883 5885 +2
- Misses 745 746 +1
+ Partials 325 324 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not renderer qrcode in SSH at all, the only clients supporting it are putty and
sshprovided by ubuntu (>= 24.04), and it's not possible (yet) to detect this from PAM level, so let's just ignore it for now.And add an integration test covering this case.
Closes: #497
UDENG-4279