Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make slog print debug messages when verbose mode is enabled #541

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Make slog print debug messages when verbose mode is enabled #541

merged 2 commits into from
Sep 19, 2024

Conversation

adombeck
Copy link
Contributor

@adombeck adombeck commented Sep 18, 2024 •
edited
Loading

UDENG-4624

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.71%. Comparing base (af01acd) to head (aafb208).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   84.66%   84.71%   +0.04%     
==========================================
  Files          79       79              
  Lines        6952     6953       +1     
  Branches       75       75              
==========================================
+ Hits         5886     5890       +4     
+ Misses        744      742       -2     
+ Partials      322      321       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adombeck adombeck marked this pull request as ready for review September 18, 2024 14:56
@adombeck adombeck requested a review from a team as a code owner September 18, 2024 14:56
jibel
jibel approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@jibel jibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

didrocks
didrocks approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like the easiest approach for now, thanks!

@adombeck adombeck merged commit 7921867 into main Sep 19, 2024
7 checks passed
@adombeck adombeck deleted the fix-slog branch September 19, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didrocks didrocks didrocks approved these changes

@jibel jibel jibel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adombeck @codecov-commenter @didrocks @jibel