Implementation of the NSS client in Rust #29
Conversation
nss/src/group/mod.rs
Outdated
| Ok(r) => Response::Success(group_entries_to_groups(r.into_inner().entries)), | ||
| Err(e) => { | ||
| error!("error when listing groups: {}", e); | ||
| Response::NotFound |
There was a problem hiding this comment.
Are we sure this is the correct error for all error cases?
There was a problem hiding this comment.
Oh, I'm definitely sure it isn't 😂 This is a "temporary" thing, as we can only return a static user from the server or an error (which would be a NotFound one). I wanted to go back to this once we had a proper NSS server (after the cache implementation) so I could understand better what I should be parsing from the Error to define the return value.
Looking at aad-auth, it looks like the most common response is Unavail but, again, I need the cache implementation to understand what I should be parsing in the error message.
nss/src/main.rs
Outdated
|
|
||
| const SOCKET_PATH: &str = "/run/authd.sock"; | ||
|
|
||
| // This main function is only used for manual testing without the need to link the NSS library and should be removed before the release |
There was a problem hiding this comment.
ack then :) Probably add a TODO so that it’s clearly marked as such
denisonbarbosa
force-pushed
the
impl-nss-client
branch
2 times, most recently
from
ce57770
to
c56896e
Compare
denisonbarbosa
force-pushed
the
impl-nss-client
branch
from
c56896e
to
c25609c
Compare
denisonbarbosa
force-pushed
the
impl-nss-client
branch
3 times, most recently
from
100d673
to
c34f978
Compare
denisonbarbosa
force-pushed
the
impl-nss-client
branch
from
348fdc1
to
fb28651
Compare
This adds the Rust code that will act as our NSS client, along with the implementation of the NSS service definition and messages in the proto files and a static implementation for the NSS server (so we could test the output on the Rust side).
UDENG-749