Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validateUILayouts logic #21

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Update validateUILayouts logic #21

merged 5 commits into from
Aug 29, 2023

Commits on Aug 29, 2023

  1. Validate UI layout based on PAM specification 

    We used to have a static verification for the UI layouts returned by the
broker, but those are subject to change according to what the system can
currently handle.

This means that it's up to PAM to provide which layouts are supported,
which fields of those layouts are required and what values those fields
support.

This replaces the previous static implementation of validateUILayouts to
a dinamic one that takes into consideration what was specified by PAM.
    @denisonbarbosa
    denisonbarbosa committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    7ce1630 View commit details
    Browse the repository at this point in the history

  2. Update broker mock with the validator changes

    @denisonbarbosa
    denisonbarbosa committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    e53c2f9 View commit details
    Browse the repository at this point in the history

  3. Export generateValidators for test purposes 

    Since this a private function only called in GetAuthenticationModes, we
need to export it to avoid having to call GAM in the
SelectAuthenticationMode tests.

We also added a helper to translate the validators into a JSON-like
string to help with the tests.
    @denisonbarbosa
    denisonbarbosa committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    fe51f3c View commit details
    Browse the repository at this point in the history

  4. Update broker tests with the validator changes

    @denisonbarbosa
    denisonbarbosa committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    5f6ede2 View commit details
    Browse the repository at this point in the history

  5. Update golden files

    @denisonbarbosa
    denisonbarbosa committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    5c4a1dc View commit details
    Browse the repository at this point in the history