Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract session mode constants #324

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Extract session mode constants #324

merged 4 commits into from
Jan 21, 2025

Conversation

adombeck
Copy link
Contributor

For improved maintainability and code navigation.

@adombeck adombeck marked this pull request as ready for review January 17, 2025 16:32
@adombeck adombeck requested a review from a team as a code owner January 17, 2025 16:32
@adombeck
Extract session mode constants
30a948c 
For improved maintainability and code navigation.
@adombeck adombeck mentioned this pull request Jan 21, 2025
Merged
@adombeck adombeck force-pushed the session-mode-constants branch from 2dee2f8 to a0fc1ec Compare January 21, 2025 11:25
didrocks
didrocks requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just think we should drop the IsChangePasswordMode helper for the reasons I gave in the previous comment. Otherwise, looking good!

internal/broker/sessionmode/consts.go Outdated Show resolved Hide resolved
internal/providers/msentraid/msentraid.go Show resolved Hide resolved
@adombeck adombeck force-pushed the session-mode-constants branch from a0fc1ec to a6d3e7e Compare January 21, 2025 13:19
@adombeck adombeck requested a review from didrocks January 21, 2025 13:32
didrocks
didrocks requested changes Jan 21, 2025
View reviewed changes
internal/broker/broker_test.go Outdated Show resolved Hide resolved
@adombeck adombeck requested a review from didrocks January 21, 2025 13:56
didrocks
didrocks approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@adombeck adombeck merged commit f989b6b into main Jan 21, 2025
3 of 4 checks passed
@adombeck adombeck deleted the session-mode-constants branch January 21, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didrocks didrocks didrocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adombeck @didrocks