Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use Microsoft Entra Security Groups #319

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Only use Microsoft Entra Security Groups #319

merged 3 commits into from
Jan 17, 2025

Conversation

adombeck
Copy link
Contributor

@adombeck adombeck commented Jan 16, 2025 •
edited
Loading

Based on #315, review and merge that first.

Other groups might be created by non-admin users.

UDENG-5795

@adombeck adombeck marked this pull request as ready for review January 16, 2025 16:37
@adombeck adombeck requested a review from a team as a code owner January 16, 2025 16:37
@adombeck adombeck requested a review from didrocks January 16, 2025 16:37
didrocks
didrocks approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusted you on the research of properties for security group. Nothing spotted if I correctly filtered what was in the log PR!

@adombeck adombeck merged commit 5b36823 into main Jan 17, 2025
3 of 4 checks passed
@adombeck adombeck deleted the UDENG-5795-only-use-security-groups branch January 17, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didrocks didrocks didrocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adombeck @didrocks