fix(updates_model): handle error on refresh (#1443)

ubuntu · Oct 6, 2023 · d4b9480 · d4b9480
1 parent 28e49cc
commit d4b9480
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 18 deletions.
diff --git a/lib/src/snapd/updates_model.dart b/lib/src/snapd/updates_model.dart
@@ -40,8 +40,12 @@ class UpdatesModel extends ChangeNotifier {
     _state = const AsyncValue.loading();
     notifyListeners();
     _state = await AsyncValue.guard(() async {
-      _refreshableSnaps = await snapd.find(filter: SnapFindFilter.refresh);
-      notifyListeners();
+      try {
+        _refreshableSnaps = await snapd.find(filter: SnapFindFilter.refresh);
+        notifyListeners();
+      } on SnapdException catch (e) {
+        _handleError(e);
+      }
     });
   }
 

diff --git a/test/updates_model_test.dart b/test/updates_model_test.dart
@@ -31,22 +31,45 @@ void main() {
     verify(service.refreshMany(const ['firefox'])).called(1);
   });
 
-  test('error stream', () async {
-    final service =
-        createMockSnapdService(refreshableSnaps: [const Snap(name: 'firefox')]);
-    final model = UpdatesModel(service);
-    when(service.refreshMany(any)).thenThrow(
-        SnapdException(message: 'error message', kind: 'error kind'));
+  group('error stream', () {
+    test('refresh', () async {
+      final service = createMockSnapdService();
+      final model = UpdatesModel(service);
+      when(service.find(filter: SnapFindFilter.refresh))
+          .thenThrow(SnapdException(
+        message: 'error while checking for updates',
+        kind: 'error kind',
+      ));
 
-    model.errorStream.listen(
-      expectAsync1<void, SnapdException>(
-        (e) {
-          expect(e.kind, equals('error kind'));
-          expect(e.message, equals('error message'));
-        },
-      ),
-    );
-    await model.refresh();
-    await model.updateAll();
+      model.errorStream.listen(
+        expectAsync1<void, SnapdException>(
+          (e) {
+            expect(e.kind, equals('error kind'));
+            expect(e.message, equals('error while checking for updates'));
+          },
+        ),
+      );
+      await model.refresh();
+    });
+    test('update all', () async {
+      final service = createMockSnapdService(
+          refreshableSnaps: [const Snap(name: 'firefox')]);
+      final model = UpdatesModel(service);
+      when(service.refreshMany(any)).thenThrow(SnapdException(
+        message: 'error while updating snaps',
+        kind: 'error kind',
+      ));
+
+      model.errorStream.listen(
+        expectAsync1<void, SnapdException>(
+          (e) {
+            expect(e.kind, equals('error kind'));
+            expect(e.message, equals('error while updating snaps'));
+          },
+        ),
+      );
+      await model.refresh();
+      await model.updateAll();
+    });
   });
 }