Skip to content

Commit

Permalink
Merge branch 'main' into track-active-changes from upstream.
Browse files Browse the repository at this point in the history
  • Loading branch information
codinesh committed Dec 24, 2023
2 parents 51b706a + b8df931 commit 4d842d2
Show file tree
Hide file tree
Showing 8 changed files with 31 additions and 33 deletions.
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
flutter 3.16.0-stable
flutter 3.16.4-stable
2 changes: 1 addition & 1 deletion melos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ command:
bootstrap:
environment:
sdk: '>=3.1.0 <4.0.0'
flutter: 3.13.9
flutter: 3.16.4

dev_dependencies:
ubuntu_lints: ^0.3.0
Expand Down
48 changes: 23 additions & 25 deletions packages/app_center/lib/src/search/search_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -48,31 +48,29 @@ class SearchPage extends StatelessWidget {
Row(children: [
Text(l10n.searchPageSortByLabel),
const SizedBox(width: 8),
Expanded(
child: Consumer(builder: (context, ref, child) {
final sortOrder = ref.watch(snapSortOrderProvider);
return MenuButtonBuilder<SnapSortOrder?>(
values: const [
null,
SnapSortOrder.alphabeticalAsc,
SnapSortOrder.alphabeticalDesc,
SnapSortOrder.downloadSizeAsc,
SnapSortOrder.downloadSizeDesc,
],
itemBuilder: (context, sortOrder, child) => Text(
sortOrder?.localize(l10n) ??
l10n.snapSortOrderRelevance,
),
onSelected: (value) => ref
.read(snapSortOrderProvider.notifier)
.state = value,
child: Text(
sortOrder?.localize(l10n) ??
l10n.snapSortOrderRelevance,
),
);
}),
),
Consumer(builder: (context, ref, child) {
final sortOrder = ref.watch(snapSortOrderProvider);
return MenuButtonBuilder<SnapSortOrder?>(
values: const [
null,
SnapSortOrder.alphabeticalAsc,
SnapSortOrder.alphabeticalDesc,
SnapSortOrder.downloadSizeAsc,
SnapSortOrder.downloadSizeDesc,
],
itemBuilder: (context, sortOrder, child) => Text(
sortOrder?.localize(l10n) ??
l10n.snapSortOrderRelevance,
),
onSelected: (value) => ref
.read(snapSortOrderProvider.notifier)
.state = value,
child: Text(
sortOrder?.localize(l10n) ??
l10n.snapSortOrderRelevance,
),
);
}),
if (query != null) ...[
const SizedBox(width: 24),
Text(l10n.searchPageFilterByLabel),
Expand Down
4 changes: 2 additions & 2 deletions packages/app_center/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ publish_to: 'none'

environment:
sdk: '>=3.1.0 <4.0.0'
flutter: 3.13.9
flutter: 3.16.4

dependencies:
app_center_ratings_client: ^1.0.0
Expand Down Expand Up @@ -43,7 +43,7 @@ dependencies:
ubuntu_logger: ^0.1.0
ubuntu_service: ^0.3.0
ubuntu_test: ^0.1.0-0
ubuntu_widgets: ^0.3.0
ubuntu_widgets: ^0.3.1
url_launcher: ^6.2.1
xdg_directories: ^1.0.3
yaru: ^1.2.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class _$ChartDataImpl implements _ChartData {
}

@override
bool operator ==(dynamic other) {
bool operator ==(Object other) {
return identical(this, other) ||
(other.runtimeType == runtimeType &&
other is _$ChartDataImpl &&
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ class _$VoteImpl implements _Vote {
}

@override
bool operator ==(dynamic other) {
bool operator ==(Object other) {
return identical(this, other) ||
(other.runtimeType == runtimeType &&
other is _$VoteImpl &&
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Mocks generated by Mockito 5.4.3 from annotations
// Mocks generated by Mockito 5.4.4 from annotations
// in app_center_ratings_client/test/ratings_client_test.dart.
// Do not manually edit this file.

Expand Down
2 changes: 1 addition & 1 deletion snap/snapcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ version: git
parts:
flutter-git:
source: https://github.com/flutter/flutter.git
source-tag: 3.13.9
source-tag: 3.16.4
source-depth: 1
plugin: nil
override-build: |
Expand Down

0 comments on commit 4d842d2

Please sign in to comment.