Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: un-cliwrap and use dnf5 instead of rpm-ostree #1954

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bsherman
Copy link
Contributor

I've been tinkering with and testing dnf5 for a while.

Key items are:

  • ensuring cliwrap is properly unwound (checked rpm-ostree Rust code)
  • using normal (not wrapped) binaries, eg for dracut
  • and the more obvious, replacing "rpm-ostree install" with "dnf5 install", etc
  • also uses dnf copr plugin to manage COPRs

Note this does NOT switch to using dnf copr plugin for ublue-os/akmods COPR since doing so removes the RPM managed repo file. That repo file needs to be renamed in the ublue-os-akmods-addons package to match the COPR naming convention.

Relates: #1946

@m2Giles
Copy link
Member

m2Giles commented Nov 21, 2024

We also need to explicitly test on both F40 and F41. We were bitten pretty hard enabling bootc in F40 with bad ISOs.

Additionally, we need to make sure that bootc label is present on our images so that we can integrate with the rest of the bootc ecosystem (F41 is good already)

@tulilirockz
Copy link
Collaborator

+1 for F41, it is working perfectly fine indeed

@tulilirockz
Copy link
Collaborator

Just realized that this will let us use https://github.com/osbuild/bootc-image-builder/ for the ISOs

@bsherman
Copy link
Contributor Author

I just force pushed an update, and some keen observers may note that I ask people NOT to force-push their PRs... this is true, but in this case there were no comments/requests for changes on any files, so no context was lost.

@bsherman bsherman marked this pull request as ready for review November 25, 2024 01:40
@bsherman bsherman requested a review from castrojo as a code owner November 25, 2024 01:40
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. dx Developer Experience Image specific labels Nov 25, 2024
@bsherman
Copy link
Contributor Author

One known problem with this...

dnf5 doesn't currently return a failing exit code when a transaction fails. This means it's possible to have failed dnf operations but not fail the build...

This is... undesirable.

I think we need to decide:

  1. do we want this now and deal with this risk
    -OR-
  2. do we wait and see if dnf5 addresses this issue before we get forced to use it as rpm-ostree deprecates functionality in favor of dnf5?

@castrojo
Copy link
Member

We can just keep this open right? Is there an open upstream issue we can track?

@bsherman
Copy link
Contributor Author

We can just keep this open right? Is there an open upstream issue we can track?

I have found a few possible issues in the dnf tracker, but I haven't nailed down the exact problem either, so I'm not sure which to track, if any truly relate.

@m2Giles
Copy link
Member

m2Giles commented Nov 25, 2024

I think we hold off while we sort out which issues to track.

I've seen some of the issues with dnf5 working with fedora 41 containers and it's very bizarre to get an error message with a 0 exit code.

@noelmiller
Copy link
Member

We can just keep this open right? Is there an open upstream issue we can track?

I have found a few possible issues in the dnf tracker, but I haven't nailed down the exact problem either, so I'm not sure which to track, if any truly relate.

@bsherman should we open an issue of our own for this in the DNF bug tracker? This would be a pretty serious bug that the DNF team and image mode for RHEL team would want to address.

Is there any way we can force a DNF command to fail in order to replicate it? Like an intentionally bad mirror or something as a test?

@tulilirockz
Copy link
Collaborator

@bsherman
Copy link
Contributor Author

We can just keep this open right? Is there an open upstream issue we can track?

I have found a few possible issues in the dnf tracker, but I haven't nailed down the exact problem either, so I'm not sure which to track, if any truly relate.

Possibly upstream issues I've found:

I've been tinkering with and testing dnf5 for a while.

Key items are:
- ensuring cliwrap is properly unwound (checked rpm-ostree Rust code)
- using normal (not wrapped) binaries, eg for dracut
- and the more obvious, replacing "rpm-ostree install" with "dnf5
  install", etc

Relates: #1946
detiber added a commit to detiber/beardy-os that referenced this pull request Dec 15, 2024
detiber added a commit to detiber/beardy-os that referenced this pull request Dec 16, 2024
detiber added a commit to detiber/beardy-os that referenced this pull request Dec 16, 2024
detiber added a commit to detiber/beardy-os that referenced this pull request Dec 16, 2024
detiber added a commit to detiber/beardy-os that referenced this pull request Dec 16, 2024
* retrofit unwrap PR from bluefin upstream

ublue-os/bluefin#1954

* add tig

* fix os-release for bluefin-dx build

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience Image specific size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants