use eslint-plugin-filename-rules

[Keyrxng]

Related to #21

• Added eslint-plugin-filename-rules

[ubiquity-os-deployer]

b4c274b

3d239c8

bf59bee

b92db67

0f9acf6

[github-actions]

Lines	Statements	Branches	Functions
	80% (4/5)	100% (0/0)	66.66% (2/3)

JUnit

Tests	Skipped	Failures	Errors	Time
1	0 💤	0 ❌	0 🔥	2.823s ⏱️

Coverage Report (80%)

File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
All files	80	100	66.66	80
main.ts	80	100	66.66	80	9

[Keyrxng]

File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
All files	92.3	75	80	92
static	80	100	66.66	80
main.ts	80	100	66.66	80	9
tests/kebab-case	95.23	75	100	95
kebab-case.ts	95.23	75	100	95	20

[gentlementlegen]

@Keyrxng does it really need to be done manually? Have you considered using eslint plugins instead like https://www.npmjs.com/package/eslint-plugin-filename-rules ? Or are there features missing in it

[Keyrxng]

I wasn't aware of that plugin @gentlementlegen. The bash script was already in use in other repos across the org I just ported it over, added some tests and tweaks to catch more file name formats.

It could be removed in favour of the plugin I don't have any problems with that.

---

Also there is no active issue for this, I just took it upon myself (won't do it again without spinning up an issue first) but I'm happy to see it through and add the plugin if you haven't already took it upon yourself

[gentlementlegen]

Would be nice if you can test the plugin and see if that can replace everything that the script is currently doing. If so, I am in favor of replacing it by the eslint package.

[Keyrxng]

no worries I'll do this today

[Keyrxng]

Would be nice if you can test the plugin and see if that can replace everything that the script is currently doing. If so, I am in favor of replacing it by the eslint package.

It'll have to be manual QA but seems to work nicely

[gentlementlegen]

@Keyrxng if you fix the conflicts in can merge this in.

[Keyrxng]

@gentlementlegen sorry bud didn't see there was conflicts

[0x4007]

What is this? @Keyrxng @gentlementlegen

Why did you accept this as a js file? Those are forbidden.

[Keyrxng]

I didn't know they were explicitly forbidden as jest.config.js is a common config file across UBQ repos but I can refactor to one of the other accepted extensions

[0x4007]

Jest is the exception if I recall correctly due to limitations

You changed this file format in this pull

[gentlementlegen]

#23 (comment)

Since it's a configuration file, didn't see much of the problem as long as it is typed. Can revert to json.

[gentlementlegen]

@0x4007 #44