Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#111 - audit dApp: Show issues with unclaimed permits #114

Closed
wants to merge 2 commits into from

Conversation

PhantomCracker
Copy link

@PhantomCracker PhantomCracker marked this pull request as draft August 9, 2023 05:38
@PhantomCracker PhantomCracker marked this pull request as ready for review August 10, 2023 10:00
@PhantomCracker
Copy link
Author

@pavlovcik can we make sure that the output is the correct one? After that I will clean and optimize the code.

@0x4007
Copy link
Member

0x4007 commented Aug 10, 2023

@pavlovcik can we make sure that the output is the correct one? After that I will clean and optimize the code.

Its better the other way around because we must QA the latest commit before merging. So we have to QA multiple times.

@rndquu How can we enable dynamic Cloudflare Pages deployments on these pull requests? I would like to be able to easily QA.

@ubiquibot
Copy link

ubiquibot bot commented Aug 10, 2023

@0x4007
Copy link
Member

0x4007 commented Aug 10, 2023

Was this manually invoked? Unusual timing after three hours from the latest commit.

@0x4007
Copy link
Member

0x4007 commented Aug 10, 2023

@pavlovcik can we make sure that the output is the correct one? After that I will clean and optimize the code.

Bad output.

Exported snippet:

Organization/Repo Name Issue URL Bounty Hunter Amount TX URL
ubiquity/pay.ubq.fi #104 - Commit hash on deployment pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #104 - Commit hash on deployment pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #100 - `audit` dApp: Better UI devpanther 300.0 WXDAI
ubiquity/pay.ubq.fi #104 - Commit hash on deployment pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #100 - `audit` dApp: Better UI devpanther 300.0 WXDAI
ubiquity/pay.ubq.fi #97 - Style Fixes pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #104 - Commit hash on deployment pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #100 - `audit` dApp: Better UI devpanther 300.0 WXDAI
ubiquity/pay.ubq.fi #97 - Style Fixes pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #104 - Commit hash on deployment pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #100 - `audit` dApp: Better UI devpanther 300.0 WXDAI
ubiquity/pay.ubq.fi #97 - Style Fixes pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #104 - Commit hash on deployment pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #100 - `audit` dApp: Better UI devpanther 300.0 WXDAI
ubiquity/pay.ubq.fi #97 - Style Fixes pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #75 - Test issue rndquu 25.0 WXDAI
ubiquity/pay.ubq.fi #104 - Commit hash on deployment pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #100 - `audit` dApp: Better UI devpanther 300.0 WXDAI
ubiquity/pay.ubq.fi #97 - Style Fixes pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #75 - Test issue rndquu 25.0 WXDAI
ubiquity/pay.ubq.fi #104 - Commit hash on deployment pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #100 - `audit` dApp: Better UI devpanther 300.0 WXDAI
ubiquity/pay.ubq.fi #97 - Style Fixes pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #75 - Test issue rndquu 25.0 WXDAI
ubiquity/pay.ubq.fi #69 - Gnosis Chain Support Venoox 400.0 WXDAI
ubiquity/pay.ubq.fi #104 - Commit hash on deployment pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #100 - `audit` dApp: Better UI devpanther 300.0 WXDAI
ubiquity/pay.ubq.fi #97 - Style Fixes pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #75 - Test issue rndquu 25.0 WXDAI
ubiquity/pay.ubq.fi #69 - Gnosis Chain Support Venoox 400.0 WXDAI
ubiquity/pay.ubq.fi #64 - Add `incentive-mode` param to config generation page Venoox 25.0 WXDAI
ubiquity/pay.ubq.fi #104 - Commit hash on deployment pavlovcik 12.5 WXDAI
ubiquity/pay.ubq.fi #100 - `audit` dApp: Better UI devpanther 300.0 WXDAI

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad output test above.

@rndquu
Copy link
Member

rndquu commented Aug 10, 2023

Was this manually invoked? Unusual timing after three hours from the latest commit.

Hard to say why the timing is so unusual. Cloudflare deployment workflow runs only on successful build. Perhaps @PhantomCracker pushed a commit to his branch and reverted it.

@PhantomCracker
Copy link
Author

Was this manually invoked? Unusual timing after three hours from the latest commit.

Hard to say why the timing is so unusual. Cloudflare deployment workflow runs only on successful build. Perhaps @PhantomCracker pushed a commit to his branch and reverted it.

No reverts on this pull request today....
@pavlovcik not all the issues does have txURL / txHash. From what I understand from @rndquu , we need to show all the closed issues, am I missing something?

@rndquu
Copy link
Member

rndquu commented Aug 10, 2023

Was this manually invoked? Unusual timing after three hours from the latest commit.

Hard to say why the timing is so unusual. Cloudflare deployment workflow runs only on successful build. Perhaps @PhantomCracker pushed a commit to his branch and reverted it.

No reverts on this pull request today.... @pavlovcik not all the issues does have txURL / txHash. From what I understand from @rndquu , we need to show all the closed issues, am I missing something?

From what I understand from @rndquu , we need to show all the closed issues

Yes, but issues should not be duplicated (as pavlovcik mentioned here)

@PhantomCracker
Copy link
Author

@rndquu so i should fix only the duplicated issues?

@rndquu
Copy link
Member

rndquu commented Aug 19, 2023

@rndquu so i should fix only the duplicated issues?

At least everything mentioned here

@rndquu
Copy link
Member

rndquu commented Sep 5, 2023

Closing because of inactivity

@rndquu rndquu closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit dApp: Show issues with unclaimed permits
3 participants