Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnosis Chain Support #69

Closed
4 tasks done
0x4007 opened this issue Jun 2, 2023 · 12 comments · Fixed by #76
Closed
4 tasks done

Gnosis Chain Support #69

0x4007 opened this issue Jun 2, 2023 · 12 comments · Fixed by #76

Comments

@0x4007
Copy link
Member

0x4007 commented Jun 2, 2023

I just tested this Gnosis Chain claim and it was successful. However there are a handful of user experience related issues that must be addressed. I went to the dApp with the current network as Ethereum Mainnet.

  • The token address link goes to an invalid address on etherscan.io because it is supposed to be checking for the token contract on gnosisscan.io
  • The token address should be converted to display the token symbol, as we have it working with DAI on mainnet.
  • When I hit claim, there was an empty error toast.

I had to refresh the page a few times to get it to work eventually. It seemed like the dApp was lagging quite bad when I tried claiming the first couple of times. The dApp should also have the following capabilities:

  • Automatically detect which network the claim is on, and request to the user to switch to that network.


Revision 20 June

Maybe a better approach would be including chain id in the URL parameter when generating a claim url on the bot, which would be cleaner in my opinion.

#76 (comment)

@0x4007
Copy link
Member Author

0x4007 commented Jun 15, 2023

I think this should be a 1 day bounty because I'm assuming that each of those tasks might take around an hour to implement.

@rndquu
Copy link
Member

rndquu commented Jun 15, 2023

I think this should be a 1 day bounty because I'm assuming that each of those tasks might take around an hour to implement.

Perhaps we should add a new Time: <4 hours label?

@0x4007
Copy link
Member Author

0x4007 commented Jun 15, 2023

I am okay with the time estimates to be coarse and not ultra precise at this stage.

We have ideas for crowdsourcing precise time estimates from the community using Thales/Synthetix and creating a betting market around it. For now I think we should default to Time: <1 Day for most tasks and try not to spend too much time thinking about the time estimate.

@malik672
Copy link

hi

@ubiquibot
Copy link

ubiquibot bot commented Jun 17, 2023

Available commands

- /assign: Assign the origin sender to the issue automatically.
- /unassign: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /payout: Disable automatic payment for the issue.
- /multiplier: Set bounty multiplier (for treasury)
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 
  ex2: /wallet vitalik.eth

@malik672

@malik672
Copy link

/assign

@malik672
Copy link

@pavlovcik is this available?

@Venoox
Copy link
Contributor

Venoox commented Jun 18, 2023

/assign

@ubiquibot
Copy link

ubiquibot bot commented Jun 18, 2023

@Venoox The time limit for this bounty is on Mon, 19 Jun 2023 09:10:53 GMT

Your currently set address is:
0x999cc482d3b04dd3dF733411687341906989Ec5B
please use /wallet 0x4FDE...BA18 if you want to update it.

@Venoox
Copy link
Contributor

Venoox commented Jun 18, 2023

@pavlovcik maybe we should use native functionality to change the network?

like this:

await window.ethereum.request({
  method: 'wallet_switchEthereumChain',
  params: [{ chainId: '0x61' }],
});

@0x4007
Copy link
Member Author

0x4007 commented Jun 18, 2023

/assign

Why did the bot ignore this assign for malik672 @0xcodercrane


@pavlovcik maybe we should use native functionality to change the network?

like this:


await window.ethereum.request({

  method: 'wallet_switchEthereumChain',

  params: [{ chainId: '0x61' }],

});

Yes I think that sounds good.

@ubiquibot
Copy link

ubiquibot bot commented Jul 5, 2023

[ CLAIM 400 WXDAI ]

0x999cc482...06989Ec5B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants