New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: download build artifact #5

Merged

rndquu merged 1 commit into main from ci/download-build-artifact

Mar 19, 2024

Member

rndquu commented Mar 18, 2024

Resolves #1 (comment)

This PR moves this workflow to the current github action


          ci: download build artifact

5bbf322

rndquu requested a review from 0x4007

March 18, 2024 16:16

rndquu mentioned this pull request

ci: remove deploy workflow ubiquity/.github#103

Merged

Member Author

rndquu commented Mar 19, 2024

I'm merging this since I want to fix all of the preview deployments today

Overall now cloudflare deploy works this way:

Build is called which uploads the build output (i.e. static html/js files) to github artifacts
Deploy workflow is called in a privileged context (i.e. with access to github secrets) so we can simply pass secrets (example) instead of hardcoding them at https://github.com/ubiquity/cloudflare-deploy-action
https://github.com/ubiquity/cloudflare-deploy-action is called here which downloads the build artifact and deploys it

rndquu merged commit c797941 into main

2 checks passed

rndquu deleted the ci/download-build-artifact branch

March 19, 2024 06:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet