-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packages #49
Update packages #49
Conversation
Just realized types are broken in CI. So this pull isn't ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with the update. Out of curiosity, why do we never pin packages to a specific version?
@gentlementlegen this test doesn't make sense to make because the config is not correct for the kernel, maybe you meant that as plugin config?
I'm not sure, but we probably should. What ends up happening is that we have |
@whilefoo I think this test was done before we updated the config, so it was using the old bot config and was valid. I didn't spot it since the test still works due to the mock, I should be changed indeed. I also agree with that, we should definitely set packages to a specific version moving forward. |
Regarding this CI run Can we simply:
|
Some packages were outdated and by upgrading the packages the types have changed so I had to fix that