Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure https plugins #48

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Secure https plugins #48

merged 5 commits into from
Jun 4, 2024

Conversation

whilefoo
Copy link
Contributor

Resolves #43

@0x4007
Copy link
Member

0x4007 commented Jun 1, 2024

Glad to see that you are pushing code again.

@whilefoo whilefoo marked this pull request as ready for review June 3, 2024 15:24
@gentlementlegen
Copy link
Member

@whilefoo Thank you for this. Will you take care of implementing it in the relevant plugins as well?

Co-authored-by: Mentlegen <[email protected]>
@whilefoo
Copy link
Contributor Author

whilefoo commented Jun 4, 2024

Yes I have implemented it in command-query-user because I needed to test it, but I'm not sure which plugins we plan to switch to workers. All plugins are short-running so I guess we can switch all?

@gentlementlegen
Copy link
Member

I believe that https://github.com/ubiquibot/comment-incentives and https://github.com/ubiquibot/user-activity-watcher would remain as Actions because they might be long running tasks. Otherwise since all the others are handling commands yes I believe they can all be Workers (and I think it's already the case).

Side note, plugins can even be hybrids with both Worker and Action if that is ever necessary someday.

@whilefoo whilefoo merged commit b4ad844 into development Jun 4, 2024
5 of 6 checks passed
@ubiquity-os-main ubiquity-os-main bot mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secure Worker routing
3 participants