fix: main entry for error free imports #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitcoindev
approved these changes
Jul 26, 2024
|
Code looks fine, will test with a fresh project and approve if there is not issue. |
gentlementlegen
approved these changes
Jul 26, 2024
|
@gentlementlegen both the commit and PR title are correctly named as per our last convo about package publishing, so merging this should update and publish automatically and correctly right? |
|
@Keyrxng It should be after we merge |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41
This does prevent the usage of
../core/or../types/but seeing as the main entry wascorewhich includes everything anyway and was the previous default it seems like this is irrelevant?QA: