Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fixed tests #58

Merged
merged 1 commit into from
Sep 24, 2024
Merged

chore: fixed tests #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/handlers/shared/start.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { Context, ISSUE_TYPE, Label } from "../../types";
import { isParentIssue, getAvailableOpenedPullRequests, getAssignedIssues, addAssignees, addCommentToIssue, getTimeValue } from "../../utils/issue";
import { checkTaskStale } from "./check-task-stale";
import { hasUserBeenUnassigned } from "./check-assignments";
import { getUserRoleAndTaskLimit } from "./get-user-task-limit-and-role";
import { addAssignees, addCommentToIssue, getAssignedIssues, getAvailableOpenedPullRequests, getTimeValue, isParentIssue } from "../../utils/issue";
import { HttpStatusCode, Result } from "../result-types";
import { hasUserBeenUnassigned } from "./check-assignments";
import { checkTaskStale } from "./check-task-stale";
import { generateAssignmentComment, getDeadline } from "./generate-assignment-comment";
import { getUserRoleAndTaskLimit } from "./get-user-task-limit-and-role";
import structuredMetadata from "./structured-metadata";
import { assignTableComment } from "./table";

Expand All @@ -17,6 +17,10 @@ export async function start(
const { logger, config } = context;
const { taskStaleTimeoutDuration } = config;

if (!sender) {
throw new Error(logger.error(`Skipping '/start' since there is no sender in the context.`).logMessage.raw);
}

// is it a child issue?
if (issue.body && isParentIssue(issue.body)) {
await addCommentToIssue(
Expand Down
17 changes: 9 additions & 8 deletions tests/main.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
import { afterAll, afterEach, beforeAll, beforeEach, describe, expect } from "@jest/globals";
import { drop } from "@mswjs/data";
import { createClient } from "@supabase/supabase-js";
import { cleanLogString, Logs } from "@ubiquity-dao/ubiquibot-logger";
import dotenv from "dotenv";
import { createAdapters } from "../src/adapters";
import { userStartStop, userUnassigned } from "../src/handlers/user-start-stop";
import { Context, envConfigValidator, Sender, SupportedEventsU } from "../src/types";
import { db } from "./__mocks__/db";
import issueTemplate from "./__mocks__/issue-template";
import { server } from "./__mocks__/node";
import usersGet from "./__mocks__/users-get.json";
import { expect, describe, beforeAll, beforeEach, afterAll, afterEach } from "@jest/globals";
import { userStartStop, userUnassigned } from "../src/handlers/user-start-stop";
import issueTemplate from "./__mocks__/issue-template";
import { createAdapters } from "../src/adapters";
import { createClient } from "@supabase/supabase-js";
import dotenv from "dotenv";
import { Logs, cleanLogString } from "@ubiquity-dao/ubiquibot-logger";

dotenv.config();

type Issue = Context<"issue_comment.created">["payload"]["issue"];
Expand Down Expand Up @@ -599,7 +600,7 @@ const maxConcurrentDefaults = {

function createContext(
issue: Record<string, unknown>,
sender: Record<string, unknown>,
sender: Record<string, unknown> | undefined,
0x4007 marked this conversation as resolved.
Show resolved Hide resolved
body = "/start",
appId: string | null = "1",
startRequiresWallet = false
Expand Down