fix: fixed /stop formatting

[cohow]

Resolves #32

[Keyrxng]

Thanks for the PR @cohow

This doesn't affect the working logic that's causing the issue

https://github.com/ubiquibot/command-start-stop/blob/a094a8c683aee3b2898049fef39f429d5e312a5d/src/handlers/shared/stop.ts#L14

})?.logMessage.diff as string)

the problem is that the error is throwing the diff string which is bubbling up into the catch-all and then it's also being wrapped in a code block.

To fix the issue use logMessage.raw instead, only addCommentToIssue() should use .diff any errors should use .raw.

[cohow]

should be good to go now I believe

To fix the issue use logMessage.raw instead, only addCommentToIssue() should use .diff any errors should use .raw.

I'll make sure to remember that for any future issue.

Thanks!

[gentlementlegen]

Seems to work fine when tested on my organization: Meniole#10 (comment)

@cohow next time please provide your own tests as well.

However, the commit names do not respect Conventional Commit name, if you can please blame and rename it.

[gentlementlegen]

Will approve when commit is renamed.

[gentlementlegen]

Why was this changed?

[cohow]

while rebasing it seems like i merged a new commit from development branch that includes that change, i’ll revert and commit new changes soon.

[cohow]

@gentlementlegen requested changes have been done, sorry about the delay I fell asleep yesterday haha.

[Keyrxng]

gentlementlegen requested changes have been done, sorry about the delay I fell asleep yesterday haha.

@cohow take a look at this cheatsheet for conventional commits. Using --no-verify when committing will bypass our checks which would highlight that your commit naming is wrong. The logic is all good though

[cohow]

gentlementlegen requested changes have been done, sorry about the delay I fell asleep yesterday haha.

@cohow take a look at this cheatsheet for conventional commits. Using --no-verify when committing will bypass our checks which would highlight that your commit naming is wrong. The logic is all good though

Okay I think I finally got it right this time... I forgot to add fix: before my apologies.

Interestingly though other repos like https://github.com/ubiquibot/conversation-rewards would not let me commit without a proper commit name. Would be very nice to implement across all repos.

[gentlementlegen]

Supposedly the webhooks should run with husky before you commit. Maybe there is something wrong with the setup on this repo, thank you for fixing.

[Keyrxng]

Would be very nice to implement across all repos.

I actually tested your commit title locally in this repo without using --no-verify and it complained and didn't let me commit so I'm certain it is implemented across all repos as it comes from our ts-template which basically every repo is forked from in one way or another, v strange lmk if you notice it again ty