Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added worker deploy / delete capabilities #29

Merged
merged 1 commit into from
Aug 28, 2024
Merged

feat: added worker deploy / delete capabilities #29

merged 1 commit into from
Aug 28, 2024

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen marked this pull request as ready for review August 28, 2024 12:31
whilefoo
whilefoo approved these changes Aug 28, 2024
View reviewed changes
Copy link

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will change the URL of the production worker right?

@gentlementlegen
Copy link
Member Author

gentlementlegen commented Aug 28, 2024 •
edited
Loading

@whilefoo It would append -main to it yes, I will fix the configurations afterwards. This won't get effective right away since these changes have to be merged to the main branch to be effective (also the one without -main will remain until I manually delete it so no downtime is needed).

@gentlementlegen gentlementlegen merged commit 273eaea into ubiquity-os-marketplace:development Aug 28, 2024
2 checks passed
@gentlementlegen gentlementlegen deleted the feat/worker-deploy-delete branch August 28, 2024 17:40
@gentlementlegen gentlementlegen mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whilefoo whilefoo whilefoo approved these changes

@0x4007 0x4007 Awaiting requested review from 0x4007

@Keyrxng Keyrxng Awaiting requested review from Keyrxng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gentlementlegen @whilefoo