feat: add a param for empty wallet

[whck6]

Resolves #22

[whck6]

I've added a new config it is called emptyWalletText.

[whck6]

@Keyrxng Do you mind checking?

[Keyrxng]

@whck6 Thanks for the PR.

Just so you know, this PR can't be merged until ubiquity/safe.ubq.fi#3 is complete as the infrastructure needed is not completely built yet. It may be best to choose another task without dependencies as it would be merged quicker.

You have correctly added a new config option but it's usage isn't right. emptyWalletText should be a string and it should be used to notify a user that they do not have a wallet registered.

---

@rndquu to keep it simple, why don't we just update the current comment to something like:

old: Please set your wallet address with the /wallet command first and try again.

suggested: If you have an ethereum wallet please register it using the /wallet command otherwise visit .... to register an account with us

I can't think how we'd choose which message to use if the flow is /wallet > !wallet > portal > /wallet. /register seems like a useless command if it only points them to the portal (because storage is handled on the UI). What do you think?

[rndquu]

I can't think how we'd choose which message to use if the flow is /wallet > !wallet > portal > /wallet. /register seems like a useless command if it only points them to the portal (because storage is handled on the UI). What do you think?

Let's just make the text configurable and decide later on the exact text content.

@whck6 Regarding the PR, although it depends on ubiquity/safe.ubq.fi#3 we can still merge it since we appreciate the help of new contributors. A few notes:

1. Why do we need this check?
2. As Keyrxng already state the emptyWalletText param is expected to be of a string type (smth like emptyWalletText: T.String({ default: "Please set your wallet address with the /wallet command first and try again." })) and used here and (perhaps) here.

@Keyrxng Overall all text messages should be configurable in the end but right now we have the only use case for "EOA vs webauthn" registration flows.

[Keyrxng]

@Keyrxng Overall all text messages should be configurable in the end but right now we have the only use case for "EOA vs webauthn" registration flows.

@rndquu my mistake I misunderstood things originally, confused myself as we had spoken about having two messages. Instead there will be only one "no wallet" message and it will be passed in via the config

[whck6]

Updated.

@rndquu I am misunderstanding and removed it

[rndquu]

The newly added emptyWalletText param should be used here and here.

[whck6]

Updated. @rndquu

[rndquu]

Works fine. @whck6 Could you also update readme docs https://github.com/ubiquibot/command-start-stop/blob/development/README.md with the newly introduced parameter?

[whck6]

Works fine. @whck6 Could you also update readme docs https://github.com/ubiquibot/command-start-stop/blob/development/README.md with the newly introduced parameter?

Updated.