Feat/teams

[Keyrxng]

Resolves #6
Requires #10

QA: ubq-testing#2 (comment)

[github-actions]

Unused files (2)

src/main.ts, src/plugin.ts

Unused dependencies (2)

Filename	dependencies
package.json	@actions/core @actions/github

Unused exports (1)

Filename	exports
src/types/plugin-input.ts	startStopSettingsValidator

Unused types (1)

Filename	types
src/types/plugin-input.ts	PluginInputs

[Keyrxng]

@0x4007 Should I impose maxConcurrentTasks checks on all teammates or just the command invoker?

[0x4007]

@0x4007 Should I impose maxConcurrentTasks checks on all teammates or just the command invoker?

I don't really understand the full context of the question. I think in the future this makes more sense to discuss under the issue specification instead.

maxConcurrentTasks is a setting that allows us to let some users only work on up to a certain amount of tasks at any given time.

Core team members should have higher limits compared to external people.

The check only happens upon task assignment /start

[Keyrxng]

given that this PR adds extends /start to allow assigning more than one person, should those checks be done against only the command invoker or should we check each user in the command string?

If done only against the invoker users could get around these checks but doing it against all might limit collaboration.

Currently the check is performed against the command invoker only

[0x4007]

Currently the check is performed against the command invoker only

check each user

Checking each user seems correct based on the vision.

[Keyrxng]

QA: ubq-testing/bot-ai#27 (comment)

There seems to be a bug that I cannot seem to resolve. In the QA issue no problems, it's a public repo and public tasks. I also have a private issue in my ubiquibot-config repo and for some reason it just will not let me assign two users at once.

I can self assign as keyrxng2 but I cannot dual-assign from either account. I am logging the assignees and both are being passed, nothing is different logic wise just the repo/issue env.

I am passing the array to the octokit.addAssignees() and when I use a for-of loop I get this rapid assigning/unassigning

---

Have you folks encountered anything like this before? I think it's actually a feature of GitHub because I cannot dual-assign via the UI either...

Should I account for this and detect if it's a private repo and comment a custom message?

[whilefoo]

I can self assign as keyrxng2 but I cannot dual-assign from either account

I'm not completely sure but I think that's because for private repos you need Github subscription to have that option

[Keyrxng]

I can self assign as keyrxng2 but I cannot dual-assign from either account

I'm not completely sure but I think that's because for private repos you need Github subscription to have that option

https://github.com/orgs/community/discussions/7150

Seems you are correct @whilefoo. We'd need permissions to access billing to determine this I'm sure so if we are to implement some sort of custom message then would we do it by simply checking assignees.length after assigning?

Or no custom message and deal with it if we need to later?

[whilefoo]

Or no custom message and deal with it if we need to later?

I think it's fine without the messages (most orgs will have paid plans)

[0x4007]

Or no custom message and deal with it if we need to later?

I think it's fine without the messages (most orgs will have paid plans)

If this isn't a lot of work I think just include the custom error message within this pull? Seems to me like this can be handled in a few lines of code.

[gentlementlegen]

Good to go for me when you addressed the remaining comments.