Signature check #4
Open
+33
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (0%)
|
|
Can you make sure that CI passes? Alternatively make a new task for it. |
gentlementlegen
approved these changes
Jun 6, 2024
|
Before merging, @whilefoo could you pass the the public key, or could you set it yourself the in Action Env? Thanks. |
|
I'm not sure if I have access to the private key and I don't know which github app the new bot uses right now |
Can try using @gentlementlegen v2 testing bot. But yeah should be an env var |
|
Can be any dummy value as long as it works with the new bot and new plugins to get valid signatures, you can DM it to me and I'll update it if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the public key for the ubiquibot github app is retrieved from the env but later this should be a part of the SDK (or at least plugin starter template) so plugin developers don't have to worry about that