Skip to content
This repository has been archived by the owner on Nov 8, 2017. It is now read-only.

Feature: Add destroy function that removes the plugin and its bindings #186

Merged
merged 1 commit into from
Mar 2, 2015

Conversation

hinshun
Copy link
Contributor

@hinshun hinshun commented Jan 30, 2015

For issue #185

@smcclstocks
Copy link

would love to see this accepted. +1

@smcclstocks
Copy link

+1

@aemkei
Copy link
Member

aemkei commented Feb 26, 2015

Not sure about google.maps.event.clearInstanceListeners because it might cause some side effects. But I'll merge it and hope it will work for you!

@aemkei aemkei closed this Feb 26, 2015
@cmwelsh
Copy link

cmwelsh commented Feb 27, 2015

But I'll merge it and hope it will work for you!

It looks like you closed this pull request without merging... :)

@aemkei aemkei reopened this Mar 2, 2015
aemkei added a commit that referenced this pull request Mar 2, 2015
Feature: Add destroy function that removes the plugin and its bindings
@aemkei aemkei merged commit 7d71f44 into ubilabs:master Mar 2, 2015
@aemkei
Copy link
Member

aemkei commented Mar 2, 2015

D'oh (x.x).

@hinshun
Copy link
Contributor Author

hinshun commented Mar 2, 2015

@aemkei
I haven't encountered problems yet, but upon searching I found this related thread:
dylanfprice/angular-gm#4

May be worth changing those clearInstanceListeners to that implementation.

@smcclstocks
Copy link

will you be bumping the version for bower folks

@aemkei
Copy link
Member

aemkei commented Mar 9, 2015

@smcclstocks Done

@smcclstocks
Copy link

Thanks man.. appreciate it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants