Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize build logic. #105

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Modernize build logic. #105

wants to merge 3 commits into from

Conversation

psteiger
Copy link

@psteiger psteiger commented Sep 21, 2024 •
edited
Loading

Applies a series of changes to modernize the repository:

  • Move to Version Catalogs.
  • Use precompiled scripts for common build logic.
  • Bump library versions.
  • Bump Gradle version.
  • Use JVM Toolchain (Java 17, but source/target compatibility still at 11).
  • Resolve obvious warnings: finalize vars, use try-with-resources, etc, when applicable.

@psteiger psteiger force-pushed the modernize branch 4 times, most recently from a0932fc to 9428ec3 Compare September 23, 2024 01:15
@psteiger psteiger marked this pull request as draft September 23, 2024 01:16
@psteiger psteiger changed the title WIP: Modernize repo Modernize build logic. Sep 23, 2024
@psteiger psteiger force-pushed the modernize branch 3 times, most recently from a87f165 to b420527 Compare September 23, 2024 16:45
@psteiger psteiger marked this pull request as ready for review September 23, 2024 17:19
@psteiger psteiger force-pushed the modernize branch 2 times, most recently from 1748bba to 37ce01c Compare September 24, 2024 22:26
@psteiger
- Move to Version Catalogs.
8f43f6a 
- Use precompiled scripts for common build logic.
- Bump library versions.
- Bump Gradle version.
- Use JVM Toolchain (Java 11).
- Resolve IDE warnings that has an obviously safe resolution: finalize vars, use try-with-resources, etc, when applicable.
tyvsmith
tyvsmith approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@tyvsmith tyvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyvsmith tyvsmith tyvsmith approved these changes

@muandrew muandrew Awaiting requested review from muandrew

@davissuber davissuber Awaiting requested review from davissuber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psteiger @tyvsmith @davissuber