Feature/194 #219
Open
Feature/194 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Looks like it is hooked up correctly. I'm not sure what the definition of done here is since we don't have the other user-specific pages up. Is it OK, that there isn't any indicators of signing in? Maybe a GET/user to get your username and display it somewhere in the nav bar? I haven't done too much on the front end so I'd like someone else to approve/advise on this. |
frostyshadows
requested changes
Apr 5, 2019
| @@ -0,0 +1,12 @@ | |||
| const store = { | |||
There was a problem hiding this comment.
looks like this file appeared because of a Git issue, it should be safe to delete
| responseHTML = 'Account successfully created'; | ||
| } else { | ||
| responseHTML = <font color='#ff0000'> {response} </font>; |
There was a problem hiding this comment.
I saw that you set color='blue' on a button in another part of the code, is it possible to do color='red' here?
| } | ||
| var encodedKey = encodeURIComponent(property); | ||
| var encodedValue = encodeURIComponent(details[property]); | ||
| formBody.push(encodedKey + '=' + encodedValue); |
There was a problem hiding this comment.
could use a string template here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔨 Changes
Connected signup/login forms to the backend. I have changed the name for the Username/email part of the login form to just email, since the backend doesn't support logging in using username.
:squirrel: Testing instructions
📄 Relevant screenshots or documentation links
📋 Checklist