Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Clear Expired Jobs Script to Make HTTP Requests Asynchrono… #215

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cormacjmollitor
Copy link
Collaborator

…usly

🔨 Changes

HTTP requests to job URL's are now asynchronous

:squirrel: Testing instructions

📄 Relevant screenshots or documentation links

📋 Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cowmanjoe
Copy link
Collaborator

cowmanjoe commented Mar 28, 2019

I'm getting occasional hanging and I'm not sure why. Maybe we should have a timeout on each individual HTTP request so that one HTTP request can't hang the whole thing.

Also, I think there may be a rate limit for hitting ZipRecruiter website jobs (jobs with link at ziprecruiter.com domain) because I got this notice when trying to access a job manually:
this.

This was when I tried to do this multiple times on over 1000 jobs. One other thing that happened when it didn't hang though is that it deleted jobs on the second run that weren't deleted on the first run. Any ideas on why this would be happening? Sorry for the long comment that really only raised a bunch of hard questions :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants