Add pagination to ColdFront API for large query requests #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrisdaaz This looks good. Curious, what was the error and how large was your dataset? Just curious if we could bump the default page size a bit larger, maybe 1000? Also, don't forget to sign your commit. Thanks for the PR! |
|
I get an OperationalError: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love the new ColdFront API! I got an error trying the
/api/projects/?project_users=trueendpoint due to the large number of results. That might have been because I was using SQLite, but maybe this would be useful to have? I wasn't sure whatPAGE_SIZEto start with. Just a thought!