Fix bug in Study modal's redux call

ubbn · May 18, 2024 · 13beb32 · 13beb32
1 parent a9b0561
commit 13beb32
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/frontend/src/components/blog/Post.tsx b/frontend/src/components/blog/Post.tsx
@@ -39,7 +39,7 @@ const Post = () => {
 
   const saveNeuron = () => {
     if (item) {
-      dispatch(thunkUpdateNeuron(item))
+      dispatch(thunkUpdateNeuron(item, true))
       setPristine(true);
       setInitial(item)
     }

diff --git a/frontend/src/components/neuron/index.tsx b/frontend/src/components/neuron/index.tsx
@@ -88,10 +88,7 @@ const Ilearn = () => {
   };
 
   const onSave = (neuron: Neuron) => {
-    if (showEditModal) {
-      // Only set if it is edit modal
-      dispatch(thunkUpdateNeuron(neuron));
-    }
+    dispatch(thunkUpdateNeuron(neuron, showEditModal)); // Update redux only if it is edit modal
     setStudyList(studyList.map((v) => (v.id === neuron.id ? neuron : v)));
     setHasChanged(true);
     openNotification(neuron);

diff --git a/frontend/src/redux/neuronSlice.ts b/frontend/src/redux/neuronSlice.ts
@@ -144,13 +144,18 @@ export const thunkFetchConnectedNeurons = (treeId: any): AppThunk => {
   }
 };
 
-export const thunkUpdateNeuron = (item: Neuron): AppThunk => {
+export const thunkUpdateNeuron = (
+  item: Neuron,
+  updateRedix?: boolean
+): AppThunk => {
   return (dispatch) => {
     dispatch(actionStart());
     return axios
       .post(url(), { user: getUserEmail(), ...item })
       .then(({ data }) => {
-        dispatch(setNeuron(data));
+        if (updateRedix) {
+          dispatch(setNeuron(data));
+        }
         dispatch(actionFinish());
       })
       .catch(handleError(dispatch));