Clarify that UKI only has to have .linux section #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poettering
reviewed
Oct 4, 2023
|
please rebase |
poettering
reviewed
Oct 20, 2023
poettering
reviewed
Oct 20, 2023
poettering
reviewed
Oct 20, 2023
|
Maybe close #74 with this? |
keszybz
force-pushed
the
uki-sections
branch
from
daa613b to
a9d27cc
Compare
|
Rebased and updated as requested. |
DaanDeMeyer
requested changes
Apr 15, 2024
The link that was provided now is just a redirect to the ukify man page, so let's link to it directly. While using objcopy is of course still possible, getting the offsets and other details right is not trivial, so let's guide people towards ukify.
People requested clarification as to what sections are "required" in a UKI. Say that if .linux is present, it's a UKI. This is intentionally vague: depending on the use of the UKI, some other sections will almost always be present, but also depending on the intended use, those might be different sections. So let's keep the specification simple and only define the minimum necessary. When we have a proper specificiation for addons, we shall link it here. (Or maybe we'll add it here?) Closes uapi-group#74.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.