Fix example.py due to LTS update #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwbishop
requested review from
davidfee5 and
liamtoney
and removed request for
davidfee5
|
I think the updates to ALPHA is 1.00. Performing an ordinary least squares fit, NOT least trimmed squares.
/Users/ldtoney/repos/lts_array/lts_array/classes/lts_classes.py:725: RuntimeWarning: invalid value encountered in sqrt
sigma_tau[jj] = np.sqrt(tau[weights, jj, :].T @ residuals / (
/Users/ldtoney/repos/lts_array/lts_array/classes/lts_classes.py:507: RuntimeWarning: invalid value encountered in cdouble_scalars
D = np.sqrt(foo + (a * b - 2 * c - a2 * a / 4) / R)
/Users/ldtoney/repos/lts_array/lts_array/classes/lts_classes.py:508: RuntimeWarning: invalid value encountered in cdouble_scalars
E = np.sqrt(foo - (a * b - 2 * c - a2 * a / 4) / R) # ...Related to NaNs? |
Whoops. I meant "warning" here. Looks good! |
liamtoney
approved these changes
Jan 26, 2023
I made a note on the |
|
Are we good to merge here? Currently if someone tries |
davidfee5
approved these changes
Feb 17, 2023
|
@jwbishop want to merge this into the main branch? or I can. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates example to address the update to the least trimmed squares processing code.
Fixes #39.