Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed 'wind_2min_timestamp' variable type from character to date-ti… #52

Merged
merged 7 commits into from
Aug 4, 2023
Merged

Changed 'wind_2min_timestamp' variable type from character to date-ti… #52

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c58cd0d
Changed 'wind_2min_timestamp' variable type from character to date-ti…
jeremylweiss Jul 25, 2023
50e9c94
upgrades to values of date-time variables
jeremylweiss Jul 26, 2023
db866c4
Merge branch 'main' into 2min-wind-timestamp-variable-type
jeremylweiss Jul 28, 2023
cd866fa
Handling of `nodata` with `wind_2min_timestamp`
jeremylweiss Jul 29, 2023
8c49f1a
Update R/az_daily.R
jeremylweiss Aug 4, 2023
db131a1
Update R/az_daily.R
jeremylweiss Aug 4, 2023
df66f73
removing extra `across()` function
jeremylweiss Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

- Transfered maintainance of package to Jeremy Weiss
- Timestamp for hourly and daily maximum two-minute sustained wind speeds now appears in downloaded data
- Variable type for hourly and daily `wind_2min_timestamp` now is date-time instead of character with correct time zone, `tzone = "America/Phoenix"`
- Values for hourly `date_datetime` variable now have `tzone = "America/Phoenix"` assigned

# azmetr 0.2.0

Expand Down
1 change: 1 addition & 0 deletions R/az_daily.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ az_daily <- function(station_id = NULL, start_date = NULL, end_date = NULL) {
)) %>%
dplyr::filter(.data$meta_station_id != "az99") %>%
dplyr::mutate(datetime = lubridate::ymd(.data$datetime)) %>%
dplyr::mutate(wind_2min_timestamp = lubridate::with_tz(lubridate::parse_date_time(.data$wind_2min_timestamp, orders = "ymdHMSz"), tzone = "America/Phoenix")) %>%
#convert NAs
dplyr::mutate(
dplyr::across(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just below this is code to change values like -9999 to NA, but it currently skips wind_2min_timestamp. I think all you need to do is:

...
dplyrr::across(
  c(wind_2min_timestamp, tidyselect(where(is.numeric))), 
  function(x)
  ...

Copy link
Member Author

@jeremylweiss jeremylweiss Jul 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without adding the above code to include wind_2min_timestamp in the conversion of NAs, existing code with wind_2min_timestamp as character automatically converts corresponding nodata values of -99999 to NA while throwing a warning 27 failed to parse, as with

az_daily(start_date = "2023-03-22", end_date = "2023-03-22")

Only one of the 28 stations at that point had wind_2min_timestamp daily values on that date.

I think the nodata value conversion needs to happen somehow in conjunction with character-to-datetime conversion of this variable.

Copy link
Member Author

@jeremylweiss jeremylweiss Jul 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the above code has trouble with wind_2min_timestamp, as it is an object of class "c('POSIXct', 'POSIXt')". This is after the character-to-datetime conversion

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aariq please review solutions in az_daily() and az_hourly() I just pushed on this branch. I think I figured it out

Expand Down
3 changes: 2 additions & 1 deletion R/az_hourly.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ az_hourly <- function(station_id = NULL, start_date_time = NULL, end_date_time =
as.numeric
)) %>%
dplyr::filter(.data$meta_station_id != "az99") %>%
dplyr::mutate(date_datetime = lubridate::ymd_hms(.data$date_datetime)) %>%
dplyr::mutate(date_datetime = lubridate::force_tz(lubridate::ymd_hms(.data$date_datetime), tzone = "America/Phoenix")) %>%
dplyr::mutate(wind_2min_timestamp = lubridate::with_tz(lubridate::parse_date_time(.data$wind_2min_timestamp, orders = "ymdHMSz"), tzone = "America/Phoenix")) %>%
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between force_tz() and with_tz()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that both handle date_datetime and wind_2min_timestamp without any warning message while assigning the correct time zone to each variable.

With date_datetime, there is no time zone assigned to values in the database. Using force_tz directly assigns tzone = "America/Phoenix", while keeping dates and hours correct. I tested with_tz here, too, but it assigned UTC as the time zone and the corresponding dates and hours, which is wrong.

With wind_2min_timestamp, there is a time zone already assigned to values in the database. Using with_tz and tzone = "America/Phoenix" correctly assigns the desired time zone while keeping corresponding dates and hours correct.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWS.md file updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you commit and push the NEWS.md changes? I don't see them in this pull request

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, they're there now. But, I managed to make a conflict

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can show you how to deal with the merge conflict next time we meet (next Friday), or you can pick a time tomorrow or earlier next week: https://calendar.app.google/eCWobQteVLViq5NJ8
It'll be an quick fix, just something easier to show over Zoom than via email.

#convert NAs
dplyr::mutate(
dplyr::across(
Expand Down