Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuaC is published!! #93

Merged
merged 8 commits into from
Nov 14, 2023
Merged

QuaC is published!! #93

merged 8 commits into from
Nov 14, 2023

Conversation

ManavalanG
Copy link
Member

Pull request

Please add a clear description of what the PR is about:

Now that QuaC is published in JOSS, this PR updates the repo with the following:

  • Citation info
  • Adds JOSS badge
  • Updates zenodo badge to use generic DOI instead of a version-specific DOI.

Please fill in the checklist below and comment as needed:

  • Was code modified? Briefly describe. No.
  • Was documentation modified? Briefly describe. Yes. See description.
  • Is this a bug-fix? Briefly describe. No.
  • Is this a feature addition? Briefly describe. No.
  • Did you modify QuaC-Watch config file? If so, did you modify multiqc template
    configs/multiqc_config_template.jinja2 and script src/quac_watch/create_mutliqc_configs.py as necessary? No.
  • Did you perform system-level testing manually, using ----cli_cluster_config and --snakemake_cluster_config
    options, as described in the documentation? Did it pass
    completely? If not why? No as no code changes were made.
  • Updated Changelog.md file with change logs in recommended format? Yes.

Anything else reviewer should know?

Branch joss_manuscript will be deleted after merging. It served its purpose!

@ManavalanG ManavalanG requested a review from wilkb777 October 27, 2023 19:17
Copy link
Member

@wilkb777 wilkb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManavalanG ManavalanG merged commit f259e65 into master Nov 14, 2023
@ManavalanG ManavalanG deleted the joss_manuscript branch November 14, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants