Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ESLint does not use lib from node_modules/@typescript/ #214

Merged
merged 5 commits into from
May 3, 2024

Conversation

u-sho
Copy link
Owner

@u-sho u-sho commented May 3, 2024

No description provided.

u-sho added 4 commits May 3, 2024 20:12
feature since TypeScript 4.5
pin vitest version, cuz typecheck is experimental
@u-sho u-sho added environment Develop environment dependencies Pull requests that update a dependency file labels May 3, 2024
@u-sho u-sho self-assigned this May 3, 2024
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quantum-game-arena ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 11:30am

@u-sho u-sho force-pushed the fix/eslint/typescript-eslint/lib-from-node_modules branch from 4d28819 to d485ea7 Compare May 3, 2024 11:30
@u-sho u-sho merged commit be30716 into develop May 3, 2024
4 of 5 checks passed
@u-sho u-sho deleted the fix/eslint/typescript-eslint/lib-from-node_modules branch May 3, 2024 11:31
u-sho added a commit that referenced this pull request May 3, 2024
* add aria-label to buttons have no text contents (#205)

* build(deps-dev): bump vite from 5.1.6 to 5.1.7 (#208)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.1.6 to 5.1.7.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.1.7/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.1.7/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [Snyk] Upgrade typescript from 5.3.3 to 5.4.2 (#207)

* fix: upgrade typescript from 5.3.3 to 5.4.2

Snyk has created this PR to upgrade typescript from 5.3.3 to 5.4.2.

See this package in npm:
https://www.npmjs.com/package/typescript

See this project in Snyk:
https://app.snyk.io/org/u-sho/project/56523540-5a4b-485d-ae86-4b4f9b0ef853?utm_source=github&utm_medium=referral&page=upgrade-pr

* fetch packge-lock.json

---------

Co-authored-by: snyk-bot <[email protected]>

* Migrate to ESLint Flat Config & [Snyk] Security upgrade eslint from 8.56.0 to 8.57.0 (#210)

* fix: package.json to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-INFLIGHT-6095116

* update typescript-eslint to v7
- `@typescript-eslint/recommended` is included in `@typescript-eslint/strict`
- `svelte/all` helps us
- almost of all browsers can parse es2023

* audit fix

* remove VSCode tabSize setting to take the advantage of tab indentation

* don't use ESLint `--cache` option

Typed lint rules almost always have dependencies on types across files in practice. https://typescript-eslint.io/troubleshooting/#can-i-use-eslints---cache-with-typescript-eslint

* update linter, typechecker, and formatter

* migrate: to ESLint Flat Config
- https://eslint.org/docs/v8.x/use/configure/migration-guide
- https://typescript-eslint.io/blog/announcing-typescript-eslint-v7/#new-features---flat-config-support
- https://sveltejs.github.io/eslint-plugin-svelte/user-guide/#new-config-eslint-config-js
- https://zenn.dev/babel/articles/eslint-flat-config-for-babel#flat-config-への移行-tips

* add ESLint option reporting unused disable directives

---------

Co-authored-by: snyk-bot <[email protected]>

* update build tools (#211)

* update build tools

* update GitHub Action
- changed version of node runtime to node20

* ignore vite temp file for 'npm run ci' command

* fix: add ignores to all eslint configs

* no need to update npm to the latest

* fix: ESLint Flat Config ignores property (#212)

The `ignores` property basically applies to all. However, when user specifies the `files`, it's not

* Refactor: remove dirty hacks from ESLint Flat Config (#213)

* remove duplicated/unused ignores

* remove dirty hack

now, does not depend on internal implementation of typescript-eslint

* use a path that makes it easy to see that it's within the same directory

* update minor dependencies include typescript-eslint

* update eslint.config.js

https://zenn.dev/u_sho/articles/eslint-flat-config-with-svelte-and-typescript

* Fix: ESLint does not use `lib` from `node_modules/@typescript/` (#214)

* fix to load `lib` from node_modules

feature since TypeScript 4.5

* drop support node<20.12

* update dependencies
pin vitest version, cuz typecheck is experimental

* share tsconfig.json options with eslint

* ✨Feature: QuantumTTT vs AI mode (#215)

* (wip) feature: add AI対戦

AIのターン中にクリックされるとバグる

* fix bug: block player click when AI thinking

* fix bug: block player click when AI resolving collapse

* fix: ESLint error

* shorten test time of sleep

* add "vs AI page" to sitemap

* v0.8.0 QuantumTTT 'vs AI' mode

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file environment Develop environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant