Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xattr fix #294

Merged
merged 3 commits into from
Dec 14, 2024
Merged

Xattr fix #294

merged 3 commits into from
Dec 14, 2024

Conversation

rminnich
Copy link
Member

No description provided.

It's a simple ls of 3 things and will quite early, rather than after
30s

Signed-off-by: Ronald G Minnich <[email protected]>
Our 9p does not support xattr. It should, someday.

Signed-off-by: Ronald G Minnich <[email protected]>
@rminnich
Copy link
Member Author

confirmed this fixes an error ericvh and I were seeing, the mounts now look like this:

localhost on /tmp/cpu type 9p (rw,nosuid,nodev,relatime,uname=rminnich,access=client,noxattr,msize=65536,trans=fd,rfd=7,wfd=7)
localhost on /usr/lib type 9p (rw,nosuid,nodev,relatime,uname=rminnich,access=client,noxattr,msize=65536,trans=fd,rfd=7,wfd=7)
localhost on /usr/lib64 type 9p (rw,nosuid,nodev,relatime,uname=rminnich,access=client,noxattr,msize=65536,trans=fd,rfd=7,wfd=7)
localhost on /usr type 9p (rw,nosuid,nodev,relatime,uname=rminnich,access=client,noxattr,msize=65536,trans=fd,rfd=7,wfd=7)
localhost on /usr/bin type 9p (rw,nosuid,nodev,relatime,uname=rminnich,access=client,noxattr,msize=65536,trans=fd,rfd=7,wfd=7)
localhost on /etc type 9p (rw,nosuid,nodev,relatime,uname=rminnich,access=client,noxattr,msize=65536,trans=fd,rfd=7,wfd=7)
localhost on /home type 9p (rw,nosuid,nodev,relatime,uname=rminnich,access=client,noxattr,msize=65536,trans=fd,rfd=7,wfd=7)

Copy link
Contributor

@ericvh ericvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but longer term we may want to look at a mntoption override on the command line to be able to adapt to different situations.

Signed-off-by: Eric Van Hensbergen [email protected]

@rminnich
Copy link
Member Author

There is actual support in there for mntopts in the structure, I'm thinking to add a session.SetMntops function for it, wdyt?

@rminnich rminnich merged commit 50f47d6 into u-root:main Dec 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants