This repository has been archived by the owner on Nov 11, 2024. It is now read-only.
Fix for uGnssPosGetStreamedStart: Return zero on success #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per documentation zero should be returned when success while nested uGnssMsgPrivateReceiveStart returns a handle. * @return zero on success or negative error code on * failure. Signed-off-by: Alon Bar-Lev <[email protected]>
|
Hi @RobMeades, I think this library should be rewritten from scratch with the cleanup pattern. if (whatever_fail) {
goto cleanup;
}
cleanup:
if (x != NULL) {
release;
}the nesting and resource management in each branch hides so many bugs... it already took me two days to trace these into the library... two days of mine == ~100 units of ublox... :) |
Surely you're not that cheap ;-). Or are we reassuringly expensive? Anyway, you make a good point, especially when the functions get rather out of hand as that one does. Thanks again, will test and merge. |
RobMeades
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per documentation zero should be returned when success while nested uGnssMsgPrivateReceiveStart returns a handle.