Custom HTML at the Top of "<body>" #1695
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded at the top of the "<body>" tag.
|
Since you have already done this, may I suggest a change to add a footer as well? (setCustomFooterElement) I am currently using a hack to add a footer using javascript like this: (I could not use the timestamp from the info page, since it is a timestamp of when the wifi-manager library files were compiled. For repeated builds, old library .o files are reused.) But having a separate setCustomFooterElement function would be a much simpler approach. |
|
This is great! I hope you don't mind, I reworked the name as "body header" and added a corresponding "footer" function, PR #1769. |
|
This should now be closed (superseded by #1769). Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added setCustomTopBodyElement allowing to define custom HTML to be added at the top of the "" tag.
This is very useful to add a custom HTML header, e. g. also a logo at the top of the page.
I know this would in general be possible with
WIFI_MANAGER_OVERRIDE_STRINGSand copying the wholewm_strings_en.hfile, however, if the only goal is to add a single line of HTML code at the top of the page this seems like a bad idea:Whenever something would get added in that file, these changes would need to be copied over manually to the custom file again.
Having the option to just "inject" and additional HTML code at the top of the body tag (similar as it is already possible to inject something at the bottom of the "head" tag) seems a much better option.