Skip to content

ci: WebサイトのCIを追加 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 31, 2025
Merged

Conversation

3w36zj6
Copy link
Member

@3w36zj6 3w36zj6 commented May 30, 2025

変更点

  • Webサイトに関連するワークフローのファイル名を実態に合わせてwebsite.ymlに変更した
  • /website/にテストランナーとしてVitestを追加した
    • Vitestはテストケースが存在しない場合に異常終了するため仮のテストケースを追加した
  • CIにBiomeとVitestを実行するJobを追加した

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the website's CI configuration by renaming the workflow file to website.yml, integrating Vitest with dummy tests to prevent abnormal exits, and adding CI jobs for both Biome and Vitest runs.

  • Renames the workflow file and updates badge links in the README.
  • Adds dummy test cases and improves test coverage for translation status, page type checks, and document flattening utilities.
  • Updates CI configurations in .github/workflows/website.yml and removes the old deploy workflow.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
website/vite.config.ts Adjusts string quotes in the server host configuration.
website/src/utils/translationStatus.test.ts Adds tests for loading, saving, and registering translation status.
website/src/utils/isPageOfKind.test.ts Provides comprehensive tests for page type determination.
website/src/utils/flattenDocs.test.ts Tests the flattenDocs utility across various hierarchy structures.
website/package.json Adds the Vitest dependency and a test script.
website/README.md Updates instructions with check and test commands.
README.md Updates CI badge to reflect the new website workflow.
.mise.toml Introduces a new dependency version pin for pinact.
.github/workflows/website.yml Implements the new CI/CD workflow for the website.
.github/workflows/deploy.yml Removes the obsolete deployment workflow.

Copy link
Member

@kimushun1101 kimushun1101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@3w36zj6 3w36zj6 merged commit 69ab344 into main May 31, 2025
5 checks passed
@3w36zj6 3w36zj6 deleted the feature/update-ci-cd-for-website branch May 31, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants