Filter nested objects #149
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow implicit deep equality check of non-array objects and use of comparison operators for deeply nested items, while preserving the original query rules (negation, logical OR). Add a setting for this behavior that defaults to false. Also provide tests for filtering nested objects and regression tests.
|
@typicaljoe @whybin Looking into this now. @whybin thank you! |
|
Hi guys! Can this feature be merged finally? |
|
IIRC this PR breaks filtering/comparison operators with arrays and may require considerable refactoring to preserve all intended behavior. I'm not inclined to fix those issues at the moment. If anyone else is interested, they are free to take a stab at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change would allow use of comparison operators at multiple levels of a deeply nested object; see #90. Original query rules still apply at deeper levels.
By default, filtering nested objects is disabled to ensure backwards compatibility.
I've added regression tests for filtering using the old behavior, as well as tests for nested query objects. All passed.