Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump class-transformer and class-validator version #827

Closed

Conversation

gtpan77
Copy link

@gtpan77 gtpan77 commented Jan 12, 2022

Description

Version bump of peer dependencies class-transformer and class-validator.
Resolves #783

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #783

@gtpan77 gtpan77 changed the title version bump: bump class-transformer and class-validator version build(deps): bump class-transformer and class-validator version Jan 12, 2022
@gtpan77 gtpan77 force-pushed the class_transformer_version_bump branch from 5697400 to 42b5b9e Compare January 12, 2022 17:30
@DAlperin
Copy link

@NoNameProvided do you mind giving this a review/merge when you get a chance? This is unfortunately breaking ci for a number of users.

@biton-ron
Copy link

biton-ron commented May 8, 2022

@NoNameProvided Hey! If you can take a look since this version of class-validator includes a very important stopAtFirstError validation setting that is not possible to activate with routing-controllers at the moment. Thanks! :)

@pfgallagher
Copy link

@attilaorosz @NoNameProvided

@FrancisBehnen
Copy link

Would it be an idea to publish a version with bumped dependencies to another NPM registry? I'm trying to use this branch, but running into issues because the typescript is not transpiled to javascript if I use the repo directly. https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-npm-registry

@attilaorosz
Copy link
Member

Closing this as it is addressed already in a different PR

@attilaorosz attilaorosz closed this Dec 9, 2022
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Please update class-transformer dependency to the latest version
7 participants