Fix node health tracking for aborted requests in cluster configuration #253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What is this?
When using Typesense in cluster configuration with request abortion enabled, the client was incorrectly marking healthy nodes as unhealthy when requests were intentionally aborted. This caused unnecessary node cycling and could degrade search performance. This change ensures that nodes remain correctly marked when requests are aborted, maintaining proper cluster health state.
Changes
Code Changes:
In
ApiCall.ts
:wasAborted
flag to track request abortion stateabortSignal
typing fromany
to properAbortSignal
DOM typewasAborted
flag when request is cancelledIn
ApiCall.spec.js
:Documentation Updates:
Context
This fixes the issue reported by @jonatansberg in #251 where nodes were being incorrectly marked as unhealthy when requests were intentionally aborted using AbortController, causing unnecessary node cycling in cluster configurations.
PR Checklist