Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloudflare] Fix the 'credentials' field on 'RequestInitializerDict' is not implemented #220

Closed
wants to merge 2 commits into from
Closed

[Cloudflare] Fix the 'credentials' field on 'RequestInitializerDict' is not implemented #220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a8bd0d
fix credentials bug
cungminh2710 Aug 8, 2024
c9618f5
Update ApiCall.ts
cungminh2710 Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Typesense/ApiCall.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,14 @@ export default class ApiCall {
],
};

// credential field is set by default (https://github.com/axios/axios/pull/6505)
// which is causing issue when running cloudflare worker (https://github.com/cloudflare/workers-sdk/issues/2514)
// We explicitly set "credentials" as undefined if it's not supported
const isCredentialsSupported = "credentials" in Request.prototype;
if (!isCredentialsSupported) {
requestOptions.withCredentials = undefined;
}

if (skipConnectionTimeout !== true) {
requestOptions.timeout = this.connectionTimeoutSeconds * 1000;
}
Expand Down
Loading