Merge pull request #246 from tharropoulos/fix-cache

Request cache: Fix type error when deleting possibly undefined oldest entry
typesense · Nov 18, 2024 · 72f0c90 · 72f0c90
2 parents 8baab7a + 72386df
commit 72f0c90
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/Typesense/RequestWithCache.ts b/src/Typesense/RequestWithCache.ts
@@ -83,13 +83,17 @@ export default class RequestWithCache {
     const isCacheOverMaxSize = this.responseCache.size > maxSize;
     if (isCacheOverMaxSize) {
       const oldestEntry = this.responseCache.keys().next().value;
-      this.responseCache.delete(oldestEntry);
+      if (oldestEntry) {
+        this.responseCache.delete(oldestEntry);
+      }
     }
     const isResponsePromiseCacheOverMaxSize =
       this.responsePromiseCache.size > maxSize;
     if (isResponsePromiseCacheOverMaxSize) {
       const oldestEntry = this.responsePromiseCache.keys().next().value;
-      this.responsePromiseCache.delete(oldestEntry);
+      if (oldestEntry) {
+        this.responsePromiseCache.delete(oldestEntry);
+      }
     }
     return response as T;
   }