Fixes Geo Distance Meters incorrect type #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change underlying type of geo_distance_meters from integer to float
fixes yml to conform to openapi
|
Note: This change assumes that the underlying node is functioning correctly and is meant to return a floating point value - for e.g. 421.0 vs 421. If this is not the case, then this PR should not be merged, and the underlying node's code should be fixed instead |
|
Thanks for the PR! This got fixed in Typesense v28 rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Changed type of
SearchResultHit.geo_distance_meters, still a key-value pair, but the type of the value has been changed fromintegertonumber($float)PR Checklist
Full details of issue in typesense/typesense-go#187