Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources to basic/recommended/talks.md #679

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

grbknr1996
Copy link
Contributor

@grbknr1996 grbknr1996 commented Oct 11, 2023

Thanks for contributing!

This solves issue #662
Add new recommended talks in talks.md

Also this is hacktoberfest if you could add the label .Thanks in advance

  • If you are making a significant PR, please make sure there is an open issue first
  • If you're just fixing typos or adding small notes, a brief explanation of why you'd like to add it would be nice :)

If you are contributing to README.md, DON'T. README.md is auto-generated. Please just make edits to the source inside of /docs/basic. Sorry, we get that it is a slight pain.

Copy link
Collaborator

@filiptammergard filiptammergard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make sure to run yarn gen-readme!

@@ -9,4 +9,5 @@ sidebar_label: Talks
- [Create a More Readable React Codebase Using TypeScript](https://youtu.be/nkJbGgieALI?si=IFZZIMEiXz7AsiBv), by Emma Brillhart 2019
- [Advanced TypeScript with React](https://youtu.be/zQfD4ZxxyKA?si=FmrgOq667svX6C9O), by Nikhil Verma 2019
- [Senior Typescript Features You don't Know About - clean-code](https://www.youtube.com/watch?v=Y4u97vJqmhM), by CoderOne 2023
- [React & TypeScript - Course for Beginners](https://www.youtube.com/watch?v=FJDVKeh7RJI),by roadsidecoder
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [React & TypeScript - Course for Beginners](https://www.youtube.com/watch?v=FJDVKeh7RJI),by roadsidecoder
- [React & TypeScript - Course for Beginners](https://www.youtube.com/watch?v=FJDVKeh7RJI), by FreeCodeCamp 2022

Copy link
Contributor Author

@grbknr1996 grbknr1996 Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the change as per suggestion ,also ran yarn gen-readme. Please resolve it

@filiptammergard filiptammergard linked an issue Oct 11, 2023 that may be closed by this pull request
README.md Outdated Show resolved Hide resolved
Co-authored-by: Filip Tammergård <[email protected]>
@filiptammergard
Copy link
Collaborator

You need to run yarn gen-readme again

@grbknr1996
Copy link
Contributor Author

You need to run yarn gen-readme again

done

@filiptammergard filiptammergard merged commit e51c20c into typescript-cheatsheets:main Oct 13, 2023
5 checks passed
@grbknr1996
Copy link
Contributor Author

grbknr1996 commented Oct 13, 2023

Could you please add hacktoberfest-accepted label @filiptammergard .Thanks in advance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Basic] Add resources to basic/recommended/talks.md
2 participants