-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resources to basic/recommended/talks.md #679
Add resources to basic/recommended/talks.md #679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also make sure to run yarn gen-readme
!
docs/basic/recommended/talks.md
Outdated
@@ -9,4 +9,5 @@ sidebar_label: Talks | |||
- [Create a More Readable React Codebase Using TypeScript](https://youtu.be/nkJbGgieALI?si=IFZZIMEiXz7AsiBv), by Emma Brillhart 2019 | |||
- [Advanced TypeScript with React](https://youtu.be/zQfD4ZxxyKA?si=FmrgOq667svX6C9O), by Nikhil Verma 2019 | |||
- [Senior Typescript Features You don't Know About - clean-code](https://www.youtube.com/watch?v=Y4u97vJqmhM), by CoderOne 2023 | |||
- [React & TypeScript - Course for Beginners](https://www.youtube.com/watch?v=FJDVKeh7RJI),by roadsidecoder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [React & TypeScript - Course for Beginners](https://www.youtube.com/watch?v=FJDVKeh7RJI),by roadsidecoder | |
- [React & TypeScript - Course for Beginners](https://www.youtube.com/watch?v=FJDVKeh7RJI), by FreeCodeCamp 2022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the change as per suggestion ,also ran yarn gen-readme. Please resolve it
Co-authored-by: Filip Tammergård <[email protected]>
You need to run yarn gen-readme again |
done |
Could you please add hacktoberfest-accepted label @filiptammergard .Thanks in advance :) |
Thanks for contributing!
This solves issue #662
Add new recommended talks in talks.md
Also this is hacktoberfest if you could add the label .Thanks in advance
If you are contributing to README.md, DON'T. README.md is auto-generated. Please just make edits to the source inside of
/docs/basic
. Sorry, we get that it is a slight pain.