Support checking Java formatting #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we need to add the plugin? |
|
And what about the commands? Similar to scalafmt? |
The sbt-typelevel-ci plugin doesn't actually add the dependencies (same for scalafmt/scalafix/MiMa/etc.). Unfortunately we just need a centralized place to organize all the various commands so they are easy to toggle for users that do want to use those plugins.
Sorry, I didn't understand this question. |
I wanted to refer to these aliases: |
|
Oh, right! We should also add it there. Thanks, nice catch. |
mzuehlke
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sbt-java-formatter plugin exposes a
javafmtCheckAllcommand.https://github.com/sbt/sbt-java-formatter