Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typelevel Migration II: return of the Typelevel migration #161

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Typelevel Migration II: return of the Typelevel migration #161

merged 5 commits into from
Jul 26, 2023

Conversation

DavidGregory084
Copy link
Member

This revives #71, migrating sbt-tpolecat to sbt-typelevel.

DavidGregory084
DavidGregory084 commented Jul 18, 2023
View reviewed changes
scalafix/rules/src/main/scala/fix/v0_5.scala
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved this rule file, because it should enable us to use the github scheme to add a Scalafix migration to Scala Steward.

@DavidGregory084
Copy link
Member Author

Looks like Scalafix and Scalafmt are disagreeing about how imports should be formatted here: I’ll have to come back to this later

@DavidGregory084 DavidGregory084 force-pushed the typelevel-migration-the-second branch from 07bbc92 to 51394ee Compare July 19, 2023 09:19
@DavidGregory084 DavidGregory084 force-pushed the typelevel-migration-the-second branch from 51394ee to 14d7ed9 Compare July 19, 2023 09:21
@DavidGregory084
Copy link
Member Author

DavidGregory084 commented Jul 19, 2023 •
edited
Loading

Scalafix rules need some more work: they don’t rewrite the plugin’s autoImport object at the moment.

@DavidGregory084
Copy link
Member Author

DavidGregory084 commented Jul 23, 2023 •
edited
Loading

I think that this is good to go once scala-steward-org/scala-steward#3126 is merged and released.

@fthomas
Copy link
Member

fthomas commented Jul 26, 2023

I think that this is good to go once scala-steward-org/scala-steward#3126 is merged and released.

Btw, you don't need to wait for a new Scala Steward release. Artifact and Scalafix migrations are in effect for all Scala Steward instances as soon as the corresponding PR is merged. See https://github.com/scala-steward-org/scala-steward/blob/a09a734b7f4ba8f71f35a94194ee7ccc80f1c848/modules/core/src/main/resources/scalafix-migrations.conf#L1-L5.

@DavidGregory084
Copy link
Member Author

Oh sweet, in that case let's go 🚀

@DavidGregory084 DavidGregory084 merged commit 62d8fe9 into main Jul 26, 2023
@DavidGregory084 DavidGregory084 deleted the typelevel-migration-the-second branch July 26, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge Awaiting requested review from armanbilge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidGregory084 @fthomas